Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#614 - Consistent message ID & FlaggableElement fix #656

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

Klotske
Copy link
Contributor

@Klotske Klotske commented Jan 12, 2023

Might close #614.

Introduced consistent ID's; Changed typings to include frontend_message_id.
Included message type in props, separated props from function definitions.

Changed FlaggableElement component & /api/set_label api route to fix report sending.

Fixed Chakra error in MessageTableEntry component (LinkOverlay is redundant).

Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably a little more cleanup to the message issue left but this is 90% of what we needed

@fozziethebeat
Copy link
Collaborator

Merging, this hasn't incorporated the end2end test fixes so the failure is expected

@fozziethebeat fozziethebeat merged commit 2ba9340 into LAION-AI:main Jan 13, 2023
@Klotske Klotske deleted the message-id-fix branch January 14, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Cleanup: Use a consistent ID for messages
2 participants