-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md - add some notes about feature branches #659
Conversation
❌ pre-commit failed. |
wups - did this quick in browser and made branch in LAION-AI repo by mistake instead of my fork. I will be sure to delete that branch once closed. |
|
||
- At any point you can compare your feature branch to the upstream/main of | ||
`LAION-AI/Open-Assistant` but using a URL like this: | ||
https://github.com/LAION-AI/Open-Assistant/compare/main...andrewm4894:Open-Assistant:my-example-feature-branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this an env variable: ${MY_GITHUB_HANDLE}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda wanted to have a link they could click and see something so they can see a real example and what to expect and then just adjust the url for their own use case.
actually might try get best of both worlds by updating the text below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will help. Maybe take a look at this other project's instructions and crib some of the steps.
❌ pre-commit failed. |
1 similar comment
❌ pre-commit failed. |
…-about-feature-branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
main
.