website: Enable label when clicking on disabled slider #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othrayte
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
fozziethebeat
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #565 (Enable category when using sliders in message reporting popup)
The original idea was that if the user clicked on the slider before checking the item it would be checked in addition to setting the slider, however that was only possible if the sliders were already enabled, which made it unclear that the items were disabled and what the checkbox did.
This solution just enables the label if the user clicks on the disabled slider and then they see it is enabled and can move it.
The amount of refactoring of this component was required for the original idea, but I hope it's considered an improvement so I've left it in.