Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

592 non empty text #684

Merged
merged 4 commits into from
Jan 13, 2023
Merged

592 non empty text #684

merged 4 commits into from
Jan 13, 2023

Conversation

melvinebenezer
Copy link
Collaborator

Solution
Handles strings with whitespaces or no text.
New TaskReplyInValid added
Submit Button is Greyed out until Valid text is available

Test Evidence

valid_string.mp4

@AbdBarho AbdBarho linked an issue Jan 13, 2023 that may be closed by this pull request
Ensure create tasks have non-empty text before submitting #592
Closed
AbdBarho
AbdBarho approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@AbdBarho AbdBarho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbdBarho AbdBarho merged commit 3d4b57c into LAION-AI:main Jan 13, 2023
@melvinebenezer melvinebenezer deleted the 592_non_empty_text branch January 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdBarho AbdBarho AbdBarho approved these changes

@fozziethebeat fozziethebeat Awaiting requested review from fozziethebeat

@k-nearest-neighbor k-nearest-neighbor Awaiting requested review from k-nearest-neighbor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure create tasks have non-empty text before submitting
2 participants
@melvinebenezer @AbdBarho