website: Fix Header.stories.js rendering add FlagsProvider #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmacarthy
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
rjmacarthy
changed the title
fozziethebeat
approved these changes
Jan 13, 2023
|
I think in a followup PR we should figure out where to put this in storybook's main wrapper code. I would have to investigate where that is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The story at
src/components/Header/Header.stories.jsxis not loading correctly in when running storybook.It needs to be wrapped in the
FlagsProvideras is using the Flags component. If theFlagscomponent is going to be used in more places it would be advisable to write a storybook decorator for it.Please let me know if you have any questions or concerns.
Thank you,