Udpating the leaderboard components to use real data #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozziethebeat
requested review from
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
reviewed
Jan 14, 2023
| ))} | ||
| </GridItem> | ||
| </Grid> | ||
| <Grid templateColumns={columns} bg={backgroundColor} borderRadius="xl" shadow="base" p="4" gap="6"> |
There was a problem hiding this comment.
is there a reason why these need to be 2 separate grids?
the columns won't be aligned between the headers & the rows.
There was a problem hiding this comment.
Right now they line up well enough with the column fields.
But I think the answer is no, they can be the same grid or a simple table. Ultimately I think this component and LeaderboardTable should be the same. But I want to assign that as a UI cleanup to Riley as he's better at that than I am. I mostly wanted to do a little re-organizational cleanup and fold in the real data.
AbdBarho
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #672
This does a few things:
RankItemcomponent to encapsulate all of the leaderboard grid functionality (with a rename toLeaderboardGridCell)LeaderboardTableandLeaderboardGridCellto fetch data from an API route