website: Fix responsiveness of '...' in sortable item #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othrayte
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the core issue with #685 and makes the '...' button work reliably in the sortable items and subsequent dialog easily closable.
It doesn't fix the issue where the modal dialog can be used to drag the sortable item or the fact that the '...' doesn't look like it can be clicked on.
Note: the change from PointerSensor to MouseSensor was required to make this work and dnd-kit says that PointerSensor shouldn't be used with touch sensor, but MouseSensor can be.