Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo fix + Consistent Docstrings #698

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Small typo fix + Consistent Docstrings #698

merged 3 commits into from
Jan 14, 2023

Conversation

kayjay-is-here
Copy link
Contributor

Also removed a redundant comment.

@kayjay-is-here
Small typo fix + Consistent Docstrings
8140ed1 
Also removed a redundant comment.
@kayjay-is-here
Copy link
Contributor Author

There's really no point to this, but I mean it doesn't really hurt to make it look nicer.

andreaskoepf
andreaskoepf requested changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to merge the docstring changes but I don't agree that the self-labeling comment is redundant and should be removed.

@github-actions
Copy link

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

andreaskoepf
andreaskoepf approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andreaskoepf andreaskoepf merged commit 5cd9c63 into LAION-AI:main Jan 14, 2023
@kayjay-is-here kayjay-is-here deleted the typo-fix branch January 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayjay-is-here @andreaskoepf @fozziethebeat