673 enhanced admin management #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozziethebeat
changed the title
fozziethebeat
requested review from
k-nearest-neighbor,
AbdBarho,
yk and
andreaskoepf
as code owners
AbdBarho
reviewed
Jan 14, 2023
| }, | ||
| }); | ||
| const messages = await messagesRes.json(); | ||
| const messages = await oasstApiClient.fetch_user_messages(user as string); |
There was a problem hiding this comment.
string array? or Message[]?
There was a problem hiding this comment.
Added the explicit type.
Comment on lines
+31
to
+41
| const local_user_map = local_users.reduce((result, user) => { | ||
| result.set(user.id, user.role); | ||
| return result; | ||
| }, new Map()); | ||
|
|
||
| const users = all_users.map((user) => { | ||
| const role = local_user_map.get(user.id) || "general"; | ||
| return { | ||
| ...user, | ||
| role, | ||
| }; |
There was a problem hiding this comment.
will this happen every time you open the users dashboard?
There was a problem hiding this comment.
Yes, it's not ideal and not something I want to keep for long. I think the real fix is to push the role information to the backend but that would require a variety of new routes to make that fetching and setting easier.
AbdBarho
approved these changes
Jan 14, 2023
andreaskoepf
approved these changes
Jan 14, 2023
|
Merging now that I see approval from all required people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to #673
Updates the admin views to user the backend's User API routes:
What's not supported yet: