Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off auto-commit on docs/docs/api/openapi.json as clashing with branch protection #723

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

andrewm4894
Copy link
Collaborator

@andrewm4894 andrewm4894 commented Jan 15, 2023

this PR should fix this by disabling last step to auto-commit docs/docs/api/openapi.json.

the auto-commit seems to be clashing with GH branch protection rules - will need to read up to see how to resolve.

looks like to resolve we would need to do this: seems like we need to do this: https://github.com/stefanzweifel/git-auto-commit-action#push-to-protected-branches

i think would need to be a repo admin who can make a access token the action can use.

@andrewm4894 andrewm4894 marked this pull request as ready for review January 15, 2023 00:25
@andrewm4894 andrewm4894 enabled auto-merge (squash) January 15, 2023 00:27
@andrewm4894 andrewm4894 changed the title turn off auto-commit as clashing with branch protection turn off auto-commit on docs/docs/api/openapi.json as clashing with branch protection Jan 15, 2023
@jack-michaud
Copy link
Collaborator

jack-michaud commented Jan 15, 2023

Just a thought - instead of committing the file to the *main branch of the repository, have you considered generating the file only in the gh-pages branch? I'm not familiar with the docusaurus flow, but just brainstorming ways to get around the branch protection.

Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz submit soon. This is adding unexpected and undesired behavior to web pull requests.

@andrewm4894
Copy link
Collaborator Author

Auto merge is on, it just needs approval from @yk or @andreaskoepf and should merge straight away then

@andrewm4894 andrewm4894 merged commit 124994a into LAION-AI:main Jan 15, 2023
@andrewm4894 andrewm4894 deleted the disable-api-docs-auto-commit branch January 15, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants