Fix FlaggableElement grouping issue for desktop #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaced grid with box because it wasn't using any grid props and was just calling an extra element
sandporg
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
sandporg
changed the title
fozziethebeat
approved these changes
Jan 15, 2023
|
The failed test contract seems unrelated to your changes. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (Items not grouped)
After (Items nice n' tidy)
Mobile
The reason for keeping these items grouped is to make it easier and faster to identify which message the tooltip belongs to. It also just looks awkward for a bunch of tooltips to sit in empty space
Also replaced grid with box because it wasn't using any grid props and was just calling an extra element