-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds functionality for intersecting curved polygons #590
Draft
kennyweiss
wants to merge
38
commits into
develop
Choose a base branch
from
feature/kweiss/bezier-polygon-revamp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fc42b9
to
29d3bce
Compare
633fff0
to
76f08ce
Compare
4 tasks
35252e5
to
d579c0c
Compare
d579c0c
to
3466936
Compare
1 task
c6c1eb7
to
da3fd27
Compare
TODO: precision of curvedpolygon intersection appears to be only 10^-10
The current example generates two mfem meshes and finds the pairs of possibly intersecting elements.
… high order mesh intersection example. TODO: deal with case of total inclusion and separation
…e in intersect_bezier, and adds two region test for intersect_polygon
…anged source mesh to high order mesh.
Supports loading in source and target mfem meshes from file as well as some simple mesh transformations.
…t example Also fixes a bug in loading the input mesh: We need to refine before transforming the mesh.
Breaks out function that inserts all intersection vertices into the polygons.
It now properly handles the cases where the two polygons have different numbers of edges.
* A case where there are multiple intersections along an edge, and the polygons have different numbers of edges * A regression case over linear quads where the computed intersection was (and is still) incorrect. This case has an intersection between an edge an a vertex.
… output polygons as SVG
…air of linear squares Also outputs some additional test cases as SVG.
…rithm Uses `PolygonEdge` and `Junction` helper classes to simplify the logic.
…red intersection algorithm
To help improve handling of degenerate edge-vertex intersection for primal's CurvedPolygon class.
…metry Note: currently failing for overlapped vertex.
da3fd27
to
d1c65b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feature/gunderman/bezier-polygon
branch on our currentdevelop
branchBezierCurve
class to compute sector areas and centroid, where a sector is the region defined by a curve and the originCurvedPolygon
class to primal. This encapsulates a polygon whose edges are BezierCurvesCurvedPolygon
s. The intersection regions consists of zero or more CurvedPolygons.TODO:
svg
imageintersect_polygon
algorithm