Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header only target #23

Merged
merged 6 commits into from
Jan 22, 2020
Merged

Header only target #23

merged 6 commits into from
Jan 22, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jan 21, 2020

Address issue #20

Add actual UNITS_HEADER_ONLY target
add a test using it for one of the builds
add a fuzz issue to the repo( didn't resolve it but it isn't currently tested since it wasn't connected to this PR).
update the docker files so they match the change in convention for c++ standards
Fix a fuzzing test that was failing but got bypassed in the previous merge.

@codecov-io
Copy link

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines        3621   3623    +2     
=====================================
+ Hits         3621   3623    +2
Impacted Files Coverage Δ
units/units.cpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7974034...4325f6f. Read the comment docs.

@phlptp phlptp merged commit a143fab into master Jan 22, 2020
@phlptp phlptp deleted the header_only_target branch January 22, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants