Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some case insensitive unit test for two character units. #91

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 25, 2020

FIx case insensitive pounds and a few other units which wasn't working with plural units.

Fixes Issue #90.

Issues fixed include "lb", "oz", "qt", "yd"

case insensitive "pt" is also fixed but plural reads at peta seconds in case_insensitive mode

@phlptp phlptp added the bug Something isn't working label Oct 25, 2020
@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2c68c59). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage          ?   99.52%           
=========================================
  Files             ?        5           
  Lines             ?     4436           
  Branches          ?        0           
=========================================
  Hits              ?     4415           
  Misses            ?       21           
  Partials          ?        0           

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>
@phlptp phlptp force-pushed the case_insensitive_units branch from 482b2a4 to 7c702c6 Compare October 25, 2020 22:08
@phlptp phlptp merged commit e047efb into master Oct 26, 2020
@phlptp phlptp deleted the case_insensitive_units branch October 26, 2020 12:49
phlptp added a commit that referenced this pull request Oct 26, 2020
* add some case insensitive unit test for two character units. (#91)

* add some case insensitive unit test for two character units.

* Automated formatting of repo files (#92)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>

* Automated formatting of repo files

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>
phlptp added a commit that referenced this pull request Oct 26, 2020
* add some case insensitive unit test for two character units. (#91)

* add some case insensitive unit test for two character units.

* Automated formatting of repo files (#92)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>

* Automated formatting of repo files

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>
phlptp added a commit that referenced this pull request Oct 26, 2020
* add some case insensitive unit test for two character units. (#91)

* add some case insensitive unit test for two character units.

* Automated formatting of repo files (#92)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>

* Automated formatting of repo files

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>
phlptp added a commit that referenced this pull request Oct 26, 2020
* add better options for optimal string on multiplier generation

* Automated formatting of repo files (#94)

* add some case insensitive unit test for two character units. (#91)

* add some case insensitive unit test for two character units.

* Automated formatting of repo files (#92)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>

* Automated formatting of repo files

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>

* add more test for string shortening

* Automated formatting of repo files (#95)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>

* move some testing functions into a separate definition

* Automated formatting of repo files (#96)

Co-authored-by: Philip Top <[email protected]>
Co-authored-by: HELICS-bot <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: HELICS-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants