-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some case insensitive unit test for two character units. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=========================================
Coverage ? 99.52%
=========================================
Files ? 5
Lines ? 4436
Branches ? 0
=========================================
Hits ? 4415
Misses ? 21
Partials ? 0 |
Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]>
482b2a4
to
7c702c6
Compare
phlptp
added a commit
that referenced
this pull request
Oct 26, 2020
* add some case insensitive unit test for two character units. (#91) * add some case insensitive unit test for two character units. * Automated formatting of repo files (#92) Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]> * Automated formatting of repo files Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]>
phlptp
added a commit
that referenced
this pull request
Oct 26, 2020
* add some case insensitive unit test for two character units. (#91) * add some case insensitive unit test for two character units. * Automated formatting of repo files (#92) Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]> * Automated formatting of repo files Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]>
phlptp
added a commit
that referenced
this pull request
Oct 26, 2020
* add some case insensitive unit test for two character units. (#91) * add some case insensitive unit test for two character units. * Automated formatting of repo files (#92) Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]> * Automated formatting of repo files Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]>
phlptp
added a commit
that referenced
this pull request
Oct 26, 2020
* add better options for optimal string on multiplier generation * Automated formatting of repo files (#94) * add some case insensitive unit test for two character units. (#91) * add some case insensitive unit test for two character units. * Automated formatting of repo files (#92) Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]> * Automated formatting of repo files Co-authored-by: Philip Top <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]> * add more test for string shortening * Automated formatting of repo files (#95) Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]> * move some testing functions into a separate definition * Automated formatting of repo files (#96) Co-authored-by: Philip Top <[email protected]> Co-authored-by: HELICS-bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx case insensitive pounds and a few other units which wasn't working with plural units.
Fixes Issue #90.
Issues fixed include "lb", "oz", "qt", "yd"
case insensitive "pt" is also fixed but plural reads at peta seconds in case_insensitive mode