stash conv problems before typechecking #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tragicus
force-pushed
the
typecheck-conv
branch
from
da3e18c to
f7c3504
Compare
|
Thanks. Can I also have a test? From the description of the PR is not immediately clear to me how to take advantage of the change. Also, it seems to suggest an API to force the resolution of these delayed constraints is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we enter
coq.typecheckorcoq.typecheck-tywith conversion problems in the evar map, the plugin will try to solve them immediately after typechecking, which is incorrect.