Port to the [dune] build system. #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlepigre
commented
Mar 20, 2024
apps/derive/elpi/dune
Outdated
Comment on lines
1
to
21
| (coq.theory | ||
| (name elpi.apps.derive.elpi) | ||
| (package coq-elpi) | ||
| (theories elpi)) | ||
|
|
||
| (rule | ||
| (target dummy.v) | ||
| (deps | ||
| (glob_files *.elpi)) | ||
| (action | ||
| (with-stdout-to %{target} | ||
| (echo "")))) | ||
|
|
||
| (install | ||
| (files | ||
| (glob_files (*.elpi with_prefix coq/user-contrib/elpi/apps/derive/elpi/))) | ||
| (section lib_root) | ||
| (package coq-elpi)) |
There was a problem hiding this comment.
This setup seems to work pretty well, and takes care of installing .elpi files.
The only drawback is that we need to put these files under a different path (here files are found under elpi.apps.derive.elpi, while they were under elpi.apps.derive before). That's probably not a big deal?
rlepigre
commented
Mar 20, 2024
Comment on lines
+1
to
+12
| (executable | ||
| (name gen_doc) | ||
| (libraries elpi_plugin)) | ||
|
|
||
| (rule | ||
| (targets | ||
| coq-builtin.elpi | ||
| coq-builtin-synterp.elpi | ||
| elpi-builtin.elpi) | ||
| (deps gen_doc.exe) | ||
| (mode promote) | ||
| (action (run ./gen_doc.exe))) |
There was a problem hiding this comment.
With this setup, the Elpi Document Builtins is probably useless?
rlepigre
force-pushed
the
dune
branch
2 times, most recently
from
e47fb34 to
e8adef6
Compare
|
I'll rebase and try to fix the doc target, which is a blocker |
The [_CoqProject] is still useful for editors, it was partially generated using: ``` grep "^ (name" apps/**/dune | \ grep -v src | \ sed 's/apps\/\([a-zA-Z]*\)\/\([a-zA-Z]*\)\/dune: (name \([^)]*\))/-Q apps\/\1\/\2 elpi.apps.\1.\2\n-Q _build\/default\/apps\/\1\/\2 elpi.apps.\1.\2/' | sed 's/\.theories//' ``` Co-Authored-By: Rodolphe Lepigre <[email protected]>
gares
reviewed
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes a bit further than #567, but there are still things to figure out:
coq-builtin[-synterp].elpifiles so that we can promote.