Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC str2gr conversion not in cache + adapt solve_TC wrt coq hook #646

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

FissoreD
Copy link
Collaborator

@FissoreD FissoreD commented Jul 1, 2024

adapt solve_TC wrt coq hook

  • a failing search should raise Not_found exn to be correctly managed by coq
  • only the sub_goals should be added to the shelf (cf this)
  • apps/tc/tests/lemma_with_max_impl.v test the correct behaviour of this change

str2gr

  • the conversion str2gr should be done outside the caching function (cf this) otherwise the error Global reference not found: XXX is raised.
  • Files tests/test_import/{f1 and f2}.v verify that now we have the right behavior
  • I add the module OSet in the takeover for the set of overridden modes: this ease modification of code

@FissoreD FissoreD force-pushed the tc-str2gr-not-in-cache branch from 3e1f94e to 85cc3b6 Compare July 1, 2024 18:20
@FissoreD FissoreD changed the title TC str2gr conversion not in cache TC str2gr conversion not in cache + adapt solve_TC wrt coq hook Jul 1, 2024
lemma_with_max_impl.v tests the correct behavior

Fixes #18
@FissoreD FissoreD force-pushed the tc-str2gr-not-in-cache branch from 85cc3b6 to d082ec1 Compare July 1, 2024 18:23
@gares gares merged commit 1fbc593 into LPCIC:master Jul 1, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants