-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to coq/coq#19346 (ComInductive flags) #657
Conversation
I let you add the optcomp stuff because I really don't want to deal with it. |
on it |
df52e01
to
d1fe4e1
Compare
Please merge now. (For some reason I still don't have write rights to coq-elpi.) |
Damn, we should look into that. |
Hi @gares, would it make sense to release a coq-elpi.2.2.1 compatible with coq-dev ? otherwise, no worries, but I'll need to remove the |
I can do another release, but a released version can only work on coq dev up to the day it was released, I'm not so sure I understand your request. For coq master you should track coq-elpi master |
Hi, thanks for your reply, to better explain my request:
it happens 1. and 2. don't compile anymore because in both cases, opam installs coq-hierarchy-builder.dev, which subsequently installs coq-elpi.2.2.1, which fails. See the two logs:
I don't know what's the best solution, but note that this issue may occur again later on, given coq-elpi is a main dependency of mathcomp. |
The solution is probably coq/opam#3102 |
Maybe, the opam constraints could induce that coq-hierarchy-builder.dev installs |
I don't know how to do that, but if you do, then go ahead, it seems the right fix |
There shouldn't be a need to change HB, only make the coq-elpi released version package stop claiming to be compatible with arbitrarily high coq versions when it's only compatible with coq versions that were already released when the coq-elpi was released. |
I agree with you, this should be enough. (I restarted the mathcomp+coq-dev builds, hopefully the build/deployment will be OK now.) |
No description provided.