Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to coq/coq#19346 (ComInductive flags) #657

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

SkySkimmer
Copy link
Collaborator

No description provided.

@SkySkimmer
Copy link
Collaborator Author

I let you add the optcomp stuff because I really don't want to deal with it.

@gares
Copy link
Contributor

gares commented Jul 11, 2024

on it

@gares gares marked this pull request as ready for review July 11, 2024 12:21
@gares gares force-pushed the func-auto-prop-lower branch from df52e01 to d1fe4e1 Compare July 11, 2024 12:43
@ppedrot
Copy link
Collaborator

ppedrot commented Jul 14, 2024

Please merge now. (For some reason I still don't have write rights to coq-elpi.)

@gares
Copy link
Contributor

gares commented Jul 14, 2024

Damn, we should look into that.

@gares gares merged commit 68e32cb into LPCIC:master Jul 14, 2024
42 of 44 checks passed
@SkySkimmer SkySkimmer deleted the func-auto-prop-lower branch July 14, 2024 15:53
@erikmd
Copy link
Contributor

erikmd commented Jul 14, 2024

Hi @gares,
Given this overlay is not present in the latest release of coq-elpi, 2.2.1:
the mathcomp/mathcomp:2.2.0-coq-dev and mathcomp/mathcomp-dev:coq-dev FTBFS.

would it make sense to release a coq-elpi.2.2.1 compatible with coq-dev ?

otherwise, no worries, but I'll need to remove the mathcomp/*:coq-dev images from Docker Hub.

@gares
Copy link
Contributor

gares commented Jul 14, 2024

I can do another release, but a released version can only work on coq dev up to the day it was released, I'm not so sure I understand your request. For coq master you should track coq-elpi master

@erikmd
Copy link
Contributor

erikmd commented Jul 14, 2024

Hi, thanks for your reply, to better explain my request:

  1. mathcomp/mathcomp provides images of stable releases of mathcomp + coq-dev,
  2. mathcomp/mathcomp-dev provides images of mathcomp master + coq-dev

it happens 1. and 2. don't compile anymore because in both cases, opam installs coq-hierarchy-builder.dev, which subsequently installs coq-elpi.2.2.1, which fails.

See the two logs:

I don't know what's the best solution, but note that this issue may occur again later on, given coq-elpi is a main dependency of mathcomp.

@SkySkimmer
Copy link
Collaborator Author

The solution is probably coq/opam#3102

@erikmd
Copy link
Contributor

erikmd commented Jul 14, 2024

Maybe, the opam constraints could induce that coq-hierarchy-builder.dev installs coq-elpi.dev, so that the merge of overlay could straightforwardly solve the issue in the docker-mathcomp builds? @gares, WDYT?

@gares
Copy link
Contributor

gares commented Jul 14, 2024

Maybe, the opam constraints could induce that coq-hierarchy-builder.dev installs coq-elpi.dev, so that the merge of overlay could straightforwardly solve the issue in the docker-mathcomp builds? @gares, WDYT?

I don't know how to do that, but if you do, then go ahead, it seems the right fix

@SkySkimmer
Copy link
Collaborator Author

There shouldn't be a need to change HB, only make the coq-elpi released version package stop claiming to be compatible with arbitrarily high coq versions when it's only compatible with coq versions that were already released when the coq-elpi was released.

@erikmd
Copy link
Contributor

erikmd commented Jul 14, 2024

I agree with you, this should be enough.

(I restarted the mathcomp+coq-dev builds, hopefully the build/deployment will be OK now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants