get_all_tables()
#185
Open
get_all_tables()
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| You can limit to the columns of one table by passing the `table` | ||
| parameter. By default the `<table_name>` is included, but this can be | ||
| removed setting `include_table=False`. | ||
|
|
||
| If `include_schema=True` return all columns of the db in | ||
| <schema>.<table_name>.<column_name> format. Note this will essentially | ||
| duplicate the output, as the working and production schemas have the |
There was a problem hiding this comment.
This isn't quite accurate. It assumes 1) the connection was made using a namespace and 2) dialect is not SQLite.
There was a problem hiding this comment.
Tried to make this more clear in the doc string
src/dataregistry/query.py
Outdated
|
|
||
| return table_list | ||
|
|
||
| def get_all_columns(self, table=None, include_table=True, include_schema=False): |
There was a problem hiding this comment.
Is table=None the most useful default? It depends on who uses it, I suppose. For typical users table="dataset" might be better.
There was a problem hiding this comment.
Defaulted it to the dataset table, added a note in the docstring that "None" will get back all tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
get_all_tables()function toQueryclass to return a set of the table names in the database.Also updated
get_all_columns()to be able to just return the column names from a chosen table, as well as the default behaviour of all tables.