[3.x] User Provider: Do not access rehash function in L10 #101
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was added in Laravel 11. Currently, this causes an exception when using Fortify with 2FA and Laravel 10 together with WebAuthn. In Fortify the function is called when it detects that it exists, for compatibility with Laravel 10. But since we implement this function in WebAuthn, we need to also add a check if this actually exists on the parent class. So in Laravel 10 we will just ignore the function and do nothing. This should be a sufficient workaround to support both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #101 +/- ##
======================================
Coverage ? 84.88%
Complexity ? 441
======================================
Files ? 69
Lines ? 1138
Branches ? 0
======================================
Hits ? 966
Misses ? 172
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added in Laravel 11.
Currently, this causes an exception when using Fortify with 2FA and Laravel 10 together with WebAuthn.
In Fortify the function is called when it detects that it exists, for compatibility with Laravel 10. But since we implement this function in WebAuthn, we need to also add a check if this actually exists on the parent class.
So in Laravel 10 we will just ignore the function and do nothing. This should be a sufficient workaround to support both.
Tested this in a Laravel 10 project and also tested that it will still call the parent function once defined.
Thanks for your work!