Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http scheme in url #53

Closed

Conversation

asivaneswaran
Copy link

#50

@asivaneswaran
Copy link
Author

@DarkGhostHunter Can you take a look and see if we can merge this?

@asivaneswaran
Copy link
Author

@DarkGhostHunter I fixed the 2 errors related to this MR.

@codecov
Copy link

codecov bot commented Sep 18, 2023

@asivaneswaran
Copy link
Author

@DarkGhostHunter Can you run the checks, everything should be fixed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asivaneswaran
Copy link
Author

@DarkGhostHunter Can we merge this PR please?

@asivaneswaran
Copy link
Author

@DarkGhostHunter Would it be possible to merge this please?

@asivaneswaran
Copy link
Author

Is this package still maintained?

@DarkGhostHunter
Copy link
Contributor

Is this package still maintained?

Yes, but I'm hands full under contract. Once it ends, I will get back into reviewing all PR's across the org.

@asivaneswaran
Copy link
Author

Hey, any news on this?

We are using the package and we need to start testing our tickets and we can't test until these PR's are merged.

I am not trying to rush you or anything, just wondering if I need to fork it until you can merge these or not.

@DarkGhostHunter
Copy link
Contributor

DarkGhostHunter commented Nov 8, 2023 via email

@DarkGhostHunter
Copy link
Contributor

Went my own way #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants