Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the "address" field type #187

Closed
tabacitu opened this issue Oct 17, 2016 · 1 comment
Closed

Issues with the "address" field type #187

tabacitu opened this issue Oct 17, 2016 · 1 comment
Assignees
Labels

Comments

@tabacitu
Copy link
Member

@OwenMelbz ,

I've found some issues here, wondering if you could take a look sometime, you know this part best.

  1. I can't go to EDIT an entry, empty the address field and the save that empty value to the database. It does not get saved, probably because that doesn't clear the hidden input.

  2. I get a javascript error on the CREATE screen, about parsing the JSON. I used attribute casting to array (not that it matters, I think - it's the create screen, there is no value).
    screen shot 2016-10-17 at 18 15 43
    screen shot 2016-10-17 at 18 15 50

Cheers!


Also, figured out a way for us to better test that nothing breaks when we make changes: we create an entity with ALL the field types and we include it in the Demo. So when we want to test a field, we just Add and Edit a new "Foo".

@OwenMelbz
Copy link
Contributor

@tabacitu well spotted :) Should now be able to clear old saved entries, and it wont try parse empty values with #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants