Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] upload and upload_multiple fields don't work as subfields inside relationship #4141

Closed
tabacitu opened this issue Feb 2, 2022 · 4 comments

Comments

@tabacitu
Copy link
Member

tabacitu commented Feb 2, 2022

Bug report

What I did

Tried to use upload and upload_multiple inside Cave and Story.

What I expected to happen

Work.

What happened

Uploads do not get saved, do not get shown.

What I've already tried to fix it

Nothing

Is it a bug in the latest version of Backpack?

v4.2 / v5 - whatever you call it

@tabacitu
Copy link
Member Author

Alternative - create a field that works similarly (uploads without elFinder), but does work as subfield. Eg. dropzone or media

@mobielbekeken-jan
Copy link

maybe a good temporary solution to just show the images in the subfield and a link to the crud for the related model? Like type: upload_multiple_view_only

That would work for me, the user can see the related items with images and if it needs to be edited they can do that in another view.

@tabacitu tabacitu moved this to No Status in Backpack v5.1 May 3, 2022
@tabacitu tabacitu removed this from Backpack v5.1 May 3, 2022
@tabacitu tabacitu moved this to No Status in Backpack v5.3 May 3, 2022
@tabacitu
Copy link
Member Author

tabacitu commented May 3, 2022

maybe a good temporary solution to just show the images in the subfield and a link to the crud for the related model? Like type: upload_multiple_view_only

Hmm... that would work in some use cases, indeed... but it wouldn't actually be a FIELD then, it would be a COLUMN (read-only)... so I don't think the use case is broad enough to warrant building it.

I'm moving this to v5.2 but I don't really think we should do this. Rather than bending the upload and upload_multiple fields to work like this (which I expect will be very complicated), I think it's smarter to just create an alternative field.

@tabacitu
Copy link
Member Author

Yup - I agree with past-me. Let's do a different field for this. Probably Laravel-Backpack/community-forum#20 or Laravel-Backpack/community-forum#28 or both. KISS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants