[v5][Summary] Not all fields work as subfields inside relationship

[tabacitu]

Right now, we do NOT have a clear map:

• what field types works as subfields inside repeatable?
• what field types work as subfields inside relationship?
• is there any difference between the two?

And we should. We MUST. It's just a matter of time before somebody tries a combination we haven't - and they will get a horrible experience. If we do not tell them "X does not work as subfield", they will expect everything to work as subfields. So we need to TEST EVERYTHING, KNOW what works and what doesn't and DOCUMENT what works and what doesn't. Then, one by one, we can make them work (if it's reasonable to do so). Here's my first attempt to test EVERYTHING.

What is left untested?

• all subfields inside repeatable field - we have them inside the Dummies CRUD ✅
• all subfields inside relationship field
  • (A) work on the 1-1 interface (attributes on hasOne/morphOne) 🟨
  • (B) work on the 1-n interface (attributes on hasMany/morphMany) 🟨
  • (C) work on the n-n interface (attributes on belongsToMany/morphToMany pivot table) 🟨

So what we need to add to the Demo, to have all bases covered, are examples that use all field types as subfields, inside the yellow scenarios above. The new interfaces we just added for the relationship field. Fortunately, we already have a model with ALL field types. And they're already configured inside MonsterCrudController, we can just re-use their definition like we did in Dummies CRUD.

How do we test the untested?

We can add three new entities, Cave, Story and Hero, with the following db tables:

This means that:

• Cave hasOne Monster (there's a cave_id on the monsters table) - treats use case (A)
• Story hasMany Monster (there's a story_id on the monsters table) - treats use case (B)
• Hero hasMany Monster (there's a hero_id on the monsters` table, which also means:
  • Hero belongsToMany Story (through the monsters pivot table) - treats use case (C)
  • Story belongsToMany Hero (through the monsters pivot table)- treats use case (C)

So we can build three new CRUDs, to have ALL subfields tested in these 3 new use cases. I'll submit a PR to the demo with these three new CRUDs:

Update: PR here - Laravel-Backpack/demo#346

[tabacitu]

Now let's see which ones work and which ones don't... I'll update this table as I test...

My tests have been done with the following branches merged:

• Refactor relationship creation #4095 (create all relations at same time)
• [4.2] guess attributes for subfields too (not just fields) #4112 (subfield attribute guessing)
• [4.2] Test & demo all field types as subfields (Stories, Heroes and Caves) demo#346 (Stories, Heroes and Caves)

Legend:
⛔️ - not allowed (doesn't work, but that's expected)
❌ - not working (but probably should)
✅ - working
✅⚠️ - working with caveats / tricks / only in certain circumstances

Can I use this field type as a subfield?

Field Type	Repeatable (demo: Dummies)	1-1 relationship (demo: Caves)	1-n relationship (demo: Stories)	n-n relationship (demo: Heroes)
address_algolia	✅	✅	✅	❌ bug on save
address_google	✅	?	?	?
browse	✅	✅	✅	✅
browse_multiple	✅	✅	✅	✅
base64_image	✅	✅	✅	✅
checkbox	✅	✅	✅	✅
checklist	✅	✅	✅	?
checklist_dependency	⛔️	⛔️	⛔️	⛔️
ckeditor	✅	✅	✅	✅
color	✅	✅	✅	✅
color_picker	✅	✅	✅	✅
custom_html	✅	✅	✅	✅
date	✅	✅	✅	✅
date_picker	✅	✅	✅	✅
date_range	✅	✅ #4140	✅ #4140	?
datetime	✅	✅	✅	✅
datetime_picker	✅	✅	✅	✅
easymde	✅	✅	✅	✅
email	✅	✅	✅	✅
enum	⛔️	?	?	?
hidden	✅	✅	✅	✅
icon_picker	✅	✅	✅	✅
image	✅	✅	✅	?
month	✅	✅	✅	✅
number	✅	✅	✅	✅
password	✅	✅	✅	✅
radio	✅	✅	✅	?
range	✅	✅	✅	✅
relationship	✅⚠️	✅⚠️ w/o subfields	✅⚠️ w/o subfields	⛔️#4142
repeatable	⛔️	⛔️	⛔️	⛔️
select (1-n relationship)	✅	✅	✅	⛔️#4142
select_grouped	✅	✅	✅	⛔️#4142
select2 (1-n relationship)	✅	✅	✅	⛔️#4142
select_multiple (n-n relationship)	✅	✅	✅	⛔️#4142
select2_multiple (n-n relationship)	✅	✅	✅	⛔️#4142
select2_nested	✅	✅	✅	⛔️#4142
select2_grouped	✅	✅	✅	⛔️#4142
select_and_order	✅	✅	✅	⛔️#4142
select_from_array	✅	✅	✅	✅
select2_from_array	✅	✅	✅	✅
select2_from_ajax	✅	✅	✅	⛔️#4142
select2_from_ajax_multiple	✅	✅	✅	⛔️#4142
summernote	✅	✅	✅	✅
table	✅	✅	✅	✅
text	✅	✅	✅	✅
textarea	✅	✅	✅	✅
time	✅	✅	✅	✅
tinymce	✅	✅	✅	✅
upload	⛔️	❌#4141	❌#4141	?
upload_multiple	⛔️	❌#4141	❌#4141	?
url	✅	✅	✅	✅
video	✅	✅	✅	✅
view	✅	✅	✅	✅
week	✅	✅	✅	✅
wysiwyg	✅	✅	✅	✅

Can I use this field feature inside a subfield?

Field Type	Repeatable	1-1 relationship	1-n relationship	n-n relationship (pivot)
array syntax	✅	✅	✅	✅
fluent syntax	⛔️	⛔️	⛔️	⛔️
string syntax	✅	✅	✅	?
fake fields	✅	✅	✅	?
tabs	⛔️	⛔️	⛔️	⛔️
identifiable attribute	✅	✅	✅	✅

[tabacitu]

Priorities:

• all relationships working as subfields (fixes [4.2][Bug] Relationships don't get saved for subfields #4108 (comment) by merging Make select_multiple and select2_multiple fields works as subfields and dot.notation.fields (through calling create() recursively) #4127)
• fake fields as subfields (checks off a few boxes at the bottom of [v5][Summary] Not all fields work as subfields inside relationship #4109 (comment))
• subfields can be defined using the string syntax (checks off a few boxes at the bottom of [v5][Summary] Not all fields work as subfields inside relationship #4109 (comment))

[tabacitu]

I'm very happy with the progress on this. I've opened issues for the few cases I think we should fix before launch. Other than that... I'm comfortable with moving this to the 4.2.x board 🎉 to make it a "problem for future us".

[tabacitu]

Round-up. There are still a few things to be done here, to consider the issue completely closed:

• [Bug] select_and_order doesn't work as subfield #4138
• [Bug] address_algolia and address_google don't work as subfields #4355
• (maybe we do) [Bug] upload and upload_multiple fields don't work as subfields inside relationship #4141
• [Bug] date_range field doesn't work as subfield inside relationship #4140
• create a place in the Demo where we use Monster as a pivot table (TODO for @tabacitu )
• test all fields in said place in demo (TODO for @tabacitu )

[kee0624]

Hi, I recently just updated my laravel backpack from 4.1 to 5, and try to add the nested repeatable under the repeatable, there is an issue here like I am not allowed to click on the nested "New Item" on the nested repeatable field, but if I create the post and edit it later, I am allowed to click on the "New Item" button and it shows the nested repeated field, is it a bug or intended? And I saw the above table it said that the repeatable are not allowed to use as a subfield, so I am confused here, it should not be working, but why it is working when I edit the post.

below is my crud fields for reference.
$this->crud->addFields([ [ 'name' => 'services', 'label' => 'Services', 'type' => 'repeatable', 'subfields' => [ [ 'name' => 'title', 'label' => 'Title', ], [ 'name' => 'buttons', 'label' => 'Buttons', 'type' => 'repeatable', 'subfields' => [ 'name' => 'buttons_label', 'label' => 'Label', ], ], ], ], ]);

[pxpm]

Hello @kee0624 . It migth display on page, but surelly it's not working.

Subfields inside subfields are not supported. Some will display, some will not display and throw errors. Use at will, we do not recommend and we do not support them (for now).

thanks

[guleswine]

                [   // Checklist
                    'name'        => 'sources',
                    'label'       => "Источники",
                    'type'        => 'select2_from_array',
                    'options'     => Source::where('removed',false)->get()->pluck('name','id'),
                    'default'     => Source::where('removed',false)->get()->pluck('id')->toArray(),
                   // 'allows_null' => false,
                    'allows_multiple' => true,
                    'wrapper' => [
                        'class' => 'form-group col-md-3',
                    ],
                ],

Hey guys, I noticed this strange behavior
its subfields of relationship

[pxpm]

Hello @guleswine it's indeed strange but I guess that it might be some corner case while using default values or something like that. As far as I am aware select2_from_array was working properly as a subfield.

If you remove the default does the problem still happen ?

If so, please open a separate issue so we can have a look at and don't forget about it in the middle of this thread.

Thanks