Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add MenuCRUD version bump to v5 upgrade docs? #4324

Closed
miquelangeld opened this issue Apr 16, 2022 · 6 comments
Closed

[Bug] Add MenuCRUD version bump to v5 upgrade docs? #4324

miquelangeld opened this issue Apr 16, 2022 · 6 comments
Labels
Possible Bug A bug that was reported but not confirmed yet. triage

Comments

@miquelangeld
Copy link

Bug report

What I did

Upgrade to Backpack 5 and install the pro tools in our test environment

What I expected to happen

Achieve the upgrade

What happened

I get a dependency error:

Problem 1
- Conclusion: don't install backpack/crud 5.0.14
- Conclusion: don't install backpack/crud 5.0.13
- Conclusion: don't install backpack/crud 5.0.12
- Conclusion: don't install backpack/crud 5.0.11
- Conclusion: don't install backpack/crud 5.0.10
- Conclusion: don't install backpack/crud 5.0.9
- Conclusion: don't install backpack/crud 5.0.8
- Conclusion: don't install backpack/crud 5.0.7
- Conclusion: don't install backpack/crud 5.0.6
- Conclusion: don't install backpack/crud 5.0.5
- Conclusion: don't install backpack/crud 5.0.4
- Conclusion: don't install backpack/crud 5.0.3
- Conclusion: don't install backpack/crud 5.0.2
- Conclusion: don't install backpack/crud 5.0.1
- Conclusion: don't install backpack/crud 5.0.0
- backpack/menucrud 2.0.5 requires backpack/crud ^4.1.0|^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- backpack/menucrud 2.0.0 requires backpack/crud ^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- backpack/menucrud 2.0.1 requires backpack/crud ^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- backpack/menucrud 2.0.2 requires backpack/crud ^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- backpack/menucrud 2.0.4 requires backpack/crud ^4.1.0|^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- backpack/menucrud 2.0.5 requires backpack/crud ^4.1.0|^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- backpack/menucrud v2.0.3 requires backpack/crud ^4.0.0 -> satisfiable by backpack/crud[4.0.x-dev, 4.1.x-dev].
- Can only install one of: backpack/crud[v5.x-dev, 4.1.x-dev].
- Can only install one of: backpack/crud[v5.x-dev, 4.0.x-dev].
- Can only install one of: backpack/crud[v5.x-dev, 4.0.x-dev].
- Installation request for backpack/crud ^5.0.0 -> satisfiable by backpack/crud[5.0.0, 5.0.1, 5.0.10, 5.0.11, 5.0.12, 5.0.13, 5.0.14, 5.0.2, 5.0.3, 5.0.4, 5.0.5, 5.0.6, 5.0.7, 5.0.8, 5.0.9, v5.x-dev].
- Installation request for backpack/menucrud ^2.0 -> satisfiable by backpack/menucrud[2.0.0, 2.0.1, 2.0.2, 2.0.4, 2.0.5, v2.0.3].

What I've already tried to fix it

We upgraded to 4.1.69 backpack, but still have the same error

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there?
YES

Backpack, Laravel, PHP, DB version

Backpack: 4.1.69
php 7.4

When I run php artisan backpack:version the output is:

PHP VERSION:

PHP 7.4.3 (cli) (built: Nov 25 2021 23:16:22) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies

LARAVEL VERSION:

v8.83.8@cf430301ad17656b3d918995bcdd0454c3c119b9

BACKPACK VERSION:

4.1.69@248e2e034cedcffe01732cdce01fb3d1ecad9ffa

@welcome
Copy link

welcome bot commented Apr 16, 2022

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

  • Bug Reports, Feature Requests - Github Issues (here);
  • Quick help (How do I do X) - Gitter Chatroom;
  • Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
  • Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

@tabacitu
Copy link
Member

Hey @miquelangeld ,

Can you please try bumping the "backpack/menucrud" version to "^3.0.0" in your composer.json, then running composer update again? Does that fix it for you?

Cheers!

@tabacitu
Copy link
Member

(we didn't mention that in the upgrade guide, but it looks to me like that's needed - so that might be our mistake)

@tabacitu tabacitu added the Possible Bug A bug that was reported but not confirmed yet. label Apr 18, 2022
@tabacitu tabacitu changed the title [Bug] [Bug] Add MenuCRUD version bump to v5 upgrade docs? Apr 18, 2022
@pxpm
Copy link
Contributor

pxpm commented Apr 18, 2022

Hey @miquelangeld and @tabacitu

I had answered this some days ago on gitter. I've reworded the text in Laravel-Backpack/docs#339 to better reflect the backpack ecosystem (not all packages work without version bump).

I don't think there is much more we can do here, going to close this!

Thanks guys, cheers!

@pxpm pxpm closed this as completed Apr 18, 2022
@miquelangeld
Copy link
Author

miquelangeld commented Apr 24, 2022

Hey @miquelangeld ,

Can you please try bumping the "backpack/menucrud" version to "^3.0.0" in your composer.json, then running composer update again? Does that fix it for you?

Cheers!

Hi @tabacitu I tried and also I needed to bump langfilemanager. And composer started to update, but then I get this error:

Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover --ansi
PHP Fatal error: During class fetch: Uncaught Error: Class 'Composer\InstalledVersions' not found in /home/info.marhotels.dev/public_html/vendor/backpack/crud/src/helpers.php:296
Stack trace:
#0 /home/info.marhotels.dev/public_html/vendor/backpack/crud/src/app/Http/Controllers/Operations/FetchOperation.php(7): backpack_pro()
#1 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(444): include('/home/info.marh...')
#2 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#4 /home/info.marhotels.dev/public_html/app/Http/Controllers/Admin/HotelCrudController.php(15): spl_autoload_call()
#5 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(444): include('/home/info.marh...')
#6 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#7 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#8 [internal function]: spl_ in /home/info.marhotels.dev/public_html/app/Http/Controllers/Admin/HotelCrudController.php on line 15

Symfony\Component\ErrorHandler\Error\FatalError

During class fetch: Uncaught Error: Class 'Composer\InstalledVersions' not found in /home/info.marhotels.dev/public_html/vendor/backpack/crud/src/helpers.php:296
Stack trace:
#0 /home/info.marhotels.dev/public_html/vendor/backpack/crud/src/app/Http/Controllers/Operations/FetchOperation.php(7): backpack_pro()
#1 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(444): include('/home/info.marh...')
#2 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#4 /home/info.marhotels.dev/public_html/app/Http/Controllers/Admin/HotelCrudController.php(15): spl_autoload_call()
#5 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(444): include('/home/info.marh...')
#6 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#7 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#8 [internal function]: spl_

at app/Http/Controllers/Admin/HotelCrudController.php:15
11▕ * Class HotelCrudController
12▕ * @Package App\Http\Controllers\Admin
13▕ * @property-read \Backpack\CRUD\app\Library\CrudPanel\CrudPanel $crud
14▕ */
➜ 15▕ class HotelCrudController extends CrudController
16▕ {
17▕ use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
18▕ use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
19▕ use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;

Whoops\Exception\ErrorException

During class fetch: Uncaught Error: Class 'Composer\InstalledVersions' not found in /home/info.marhotels.dev/public_html/vendor/backpack/crud/src/helpers.php:296
Stack trace:
#0 /home/info.marhotels.dev/public_html/vendor/backpack/crud/src/app/Http/Controllers/Operations/FetchOperation.php(7): backpack_pro()
#1 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(444): include('/home/info.marh...')
#2 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#4 /home/info.marhotels.dev/public_html/app/Http/Controllers/Admin/HotelCrudController.php(15): spl_autoload_call()
#5 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(444): include('/home/info.marh...')
#6 /home/info.marhotels.dev/public_html/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#7 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#8 [internal function]: spl_

at app/Http/Controllers/Admin/HotelCrudController.php:15
11▕ * Class HotelCrudController
12▕ * @Package App\Http\Controllers\Admin
13▕ * @property-read \Backpack\CRUD\app\Library\CrudPanel\CrudPanel $crud
14▕ */
➜ 15▕ class HotelCrudController extends CrudController
16▕ {
17▕ use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
18▕ use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
19▕ use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;

  +1 vendor frames 

2 [internal]:0
Whoops\Run::handleShutdown()
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255

@miquelangeld
Copy link
Author

miquelangeld commented Apr 24, 2022

Never mind, It was a composer version issue, using composer v2 worked like a charm. I just needed to bump backpack/menucrud and also backpack/langfilemanager. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A bug that was reported but not confirmed yet. triage
Projects
None yet
Development

No branches or pull requests

3 participants