Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COLUMNS] setColumnOrder() #8

Closed
tabacitu opened this issue May 10, 2016 · 2 comments
Closed

[COLUMNS] setColumnOrder() #8

tabacitu opened this issue May 10, 2016 · 2 comments

Comments

@tabacitu
Copy link
Member

Make this work:
$this->crud->setColumnOrder(['column_1', 'column_2', 'column_3']);

The sorting functionality in the Crud.php file does not work.
Also, I don't think the $crud->sort property makes no sense now.
The sorting should just shuffle the arrays where they are, without storing the order anywhere.

@tabacitu tabacitu added this to the 3.2 - maturity milestone Jul 28, 2016
@tabacitu
Copy link
Member Author

On second thought, the order is self-evident. You type the columns/fields in an order and that's the order they're shown.

I say... drop it like it's hot.

@tjventurini
Copy link

Just want to add, you can remove the $this->crud->setFromDb(); in the Crud Controller and then manually add the columns with $this->crud->addColumns([.... Set the order of your columns as you want in addColumns().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants