Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OO typo for attributes #111

Closed
wants to merge 1 commit into from

Conversation

rahafrouz
Copy link

Hi, when using select 2, existing objects can not be shown due to this typo.

@tabacitu
Copy link
Member

Hi @rahafrouz ,

Thanks a lot for the PR. I'm a bit puzzled - how did you use the model_function_attribute column and it didn't work? I just tested it for a simple function and it seems to work as intended (if the function returns a string, that string is echoed).

Could you please post your function?

From what I can see, your function returns an array/collection of items, so you need to get the first one, correct? If so, I'm wondering it the select column type wouldn't have been a better choice.

Thanks and sorry for not understanding.

Cheers!

@tabacitu
Copy link
Member

tabacitu commented Oct 7, 2016

Hi @rahafrouz - have some time to check out my comment above? Just want to know if I can close this issue.

Cheers!

@tabacitu tabacitu closed this Oct 11, 2016
This was referenced Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants