[4.1][Improvement] Image field - allow multiple image uploaders + generate variations on save #124

OwenMelbz · 2016-09-21T10:42:51Z

Have refactored a small amount of code to allow multiple uploaders on
the page and enabled better user feedback with loaders and hiding of
buttons

Have refactored a small amount of code to allow multiple uploaders on the page and enabled better user feedback with loaders and hiding of buttons

This is an offshoot of a previous PR which I’ve closed. This uses the new image uploader frontend, however allows handling in a similar fashion as `uploadFileToDisk` by using `uploadImageToDisk` ```php $this->crud->addField([ 'name' => 'image', 'label' => 'Company Photo', 'type' => 'image', 'crop' => true, 'ratio' => '1:2', 'disk' => 'uploads' ],'both'); ``` ```php public function setImageAttribute($value) { $attribute_name = "image"; $disk = "uploads"; $destination_path = "folder_1/subfolder_3"; $this->uploadImageToDisk($value, $attribute_name, $disk, $destination_path, ['medium' => [500,500]]); return $this->attribute[$attribute_name]; } ```

[ci skip] [skip ci]

OwenMelbz · 2016-09-21T13:16:40Z

Just noticed an odd permissions issue with Intervention, so looking into it before marking it as ready again

[ci skip] [skip ci]

OwenMelbz · 2016-10-11T11:07:19Z

@tabacitu just an update, there was a previous Issue added that somebody was asking for a way to fix the issue this PR solves, maybe when you get a minute we could look at getting it integrated before too much other stuff changes :P

# Conflicts: # src/resources/views/fields/image.blade.php

[ci skip] [skip ci]

OwenMelbz · 2016-11-02T09:57:47Z

@tabacitu I've made the discussed changes and tweaked a few bits, now blockui is also included should be easier for you to test?

an example usage would be

$this->crud->addField([
            'name' => 'photo',
            'label' => 'Profile Photo',
            'type' => 'image',
            'crop' => true,
            'aspect_ratio' => '1:1',
            'disk' => 'uploads'
        ]);

public function setPhotoAttribute($value)
{
        return $value = $this->uploadImageToDisk($value, $attributeName, $disk, $uploadFolder, $variations = [
               'small' => [100,100],
               'medium' => [500, 500]
       ]);
}

OwenMelbz · 2017-02-04T08:45:44Z

@tabacitu - this PR still solves several bugs with the image field, I know it's old now and maybe seem like hard one to merge, but I think it will definitely be worth it!

P.s. Currently you can only have 1 image uploaded on the form, this also fixes that amongst other fixes

lloy0076 · 2017-07-07T22:26:06Z

src/CrudTrait.php

+    public function uploadImageToDisk($value, $attribute_name, $disk, $destination_path, $variations = null)
+    {
+        if (! $variations || ! is_array($variations)) {
+            $variations = ['original' => null, 'thumb' => [150, 150]];


That this defaults to 150x150 probably should be stated somewhere.

(less important: where did `150x150 come from?)

lloy0076 · 2017-07-07T22:26:57Z

src/CrudTrait.php

+            $variations = ['original' => null, 'thumb' => [150, 150]];
+        }
+
+        //Needed for the original image


That comment's confusing - it's needed but it's null? Does that mean the value should be set to the null value maybe?

lloy0076 · 2017-07-07T22:27:14Z

src/CrudTrait.php

+
+        //Needed for admin thumbnails
+        if (! array_key_exists('thumb', $variations)) {
+            $variations['thumb'] = [150, 150];


lloy0076 · 2017-07-07T22:29:57Z

src/CrudTrait.php

+        $disk_root = $disk_config['root'];
+
+        //if the disk is public, we need to know the public path
+        if ($disk_config['visibility'] == 'public') {


What if there is no 'visibility' key (out of morbid interest)?

Is this better as

if (config("filesystems.disks.$disk.visbility") === 'public')) { /* stuff */ }

...maybe?

lloy0076 · 2017-07-07T22:32:27Z

src/CrudTrait.php

+        if (($request->hasFile($attribute_name) || starts_with($value, 'data:image')) && $this->{$attribute_name}) {
+            foreach ($variations as $variant => $dimensions) {
+                $variant_name = str_replace('-original', '-'.$variant, $this->{$attribute_name});
+                \Storage::disk($disk)->delete($variant_name);


Just out of morbid interest, can that ever fail? (the answer is yes, but what does it do when it does?)

I'm more smoking out "errors that never get logged/cause exceptions".

lloy0076 · 2017-07-07T22:46:39Z

src/CrudTrait.php

+    }
+
+    /**
+     * Handles the retrieval of an image by variant:.


Period at the end?

lloy0076 · 2017-07-07T22:47:19Z

src/CrudTrait.php

+    /**
+     * Handles the retrieval of an image by variant:.
+     *
+     * @param  [type] $attribute        Name of the attribute within the model that contains the json


We end in periods (.) or we don't but they're mixed for some reason.

lloy0076 · 2017-07-07T22:47:50Z

src/CrudTrait.php

+     *
+     * @param  [type] $attribute        Name of the attribute within the model that contains the json
+     * @param  [type] $variant          Name of the variant you want to extract
+     * @param  [type] $disk             Filesystem disk used to store files.


We do return...but what?

lloy0076 · 2017-07-07T22:48:18Z

src/CrudTrait.php

+                $disk_config = config('filesystems.disks.'.$disk);
+                $disk_root = $disk_config['root'];
+
+                //if the disk is public, we need to know the public path


That's surely a DRY (it must be up there too!).

lloy0076 · 2017-07-07T22:50:06Z

src/CrudTrait.php

+            }
+        }
+
+        return $url;


This can be 'null' but can Storage::url($foo) ever also be null? I don't think it can in which case it's ok but if there is a difference between:

$image was not set for some reason

Storage::url() returned something funny

...we probably should allow the end user to detect that somehow. Or throw an exception.

tabacitu · 2020-02-11T12:50:47Z

@OwenMelbz & @lloy0076 - I really appreciate your work on this. But... since I've let 4 years pass, this PR is no longer in a state where it can be merged. So I'm going to have to close it.

Thanks again for all the help you guys have provided - I really appreciate it. But it's time to put this PR to sleep 😄

Cheers!

OwenMelbz · 2020-02-11T15:01:53Z

I wonder if this is possible to do now since all the updates!? 😂

tabacitu · 2020-02-11T15:09:31Z

😆 A PR from 2016 merged in 2020? I'm pretty sure if we try... we'll create a black hole. Or at least a nuclear explosion...

fixed some UI and javascript bugs

b75678a

Have refactored a small amount of code to allow multiple uploaders on the page and enabled better user feedback with loaders and hiding of buttons

OwenMelbz added the working on it label Sep 21, 2016

Owen Melbourne and others added 4 commits September 21, 2016 13:30

Applied fixes from StyleCI

cfddb76

[ci skip] [skip ci]

added column blade file for images

0332c0f

Applied fixes from StyleCI

3526d8d

[ci skip] [skip ci]

OwenMelbz added ready and removed working on it labels Sep 21, 2016

Owen Melbourne and others added 2 commits September 21, 2016 14:25

fixed bug where path was not checked correctly

e2d0c63

Applied fixes from StyleCI

422ff2d

[ci skip] [skip ci]

OwenMelbz added ready and removed working on it labels Sep 21, 2016

tabacitu added working on it and removed ready labels Sep 22, 2016

OwenMelbz changed the title ~~fixed some UI and javascript bugs~~ Image Uploader tweaks and optimisations Sep 26, 2016

OwenMelbz changed the title ~~Image Uploader tweaks and optimisations~~ [Bug Fix] [ Enhancement] Input - Allow multiple image uploaders + generate variations on save Oct 4, 2016

OwenMelbz added enhancement and removed ready labels Oct 4, 2016

OwenMelbz mentioned this pull request Oct 11, 2016

The form only displays the first image when editing an element with multiple image fields. #174

Closed

OwenMelbz added 5 commits November 1, 2016 18:11

Merge branch 'master' into image-uploader-fixes

586ee20

# Conflicts: # src/resources/views/fields/image.blade.php

included blockui

13d0d42

starting to fix merge conflict

9761699

added proper aspect ratios

86114c0

fixed issue with custom variations

e532db8

tabacitu and others added 2 commits November 2, 2016 09:46

Applied fixes from StyleCI

e5b1182

[ci skip] [skip ci]

changed default disk and fixed attribute field

346bbaf

OwenMelbz added the ready label Dec 3, 2016

OwenMelbz mentioned this pull request Dec 14, 2016

Malformed JSON in "table" field when casting #259

Closed

tabacitu removed the enhancement label Feb 2, 2017

lloy0076 reviewed Jul 7, 2017

View reviewed changes

tabacitu changed the title ~~[Bug Fix] [ Enhancement] Input - Allow multiple image uploaders + generate variations on save~~ [4.0][Improvement] Image field - allow multiple image uploaders + generate variations on save Aug 17, 2019

tabacitu added the Priority: COULD label Aug 20, 2019

tabacitu changed the title ~~[4.0][Improvement] Image field - allow multiple image uploaders + generate variations on save~~ [4.1][Improvement] Image field - allow multiple image uploaders + generate variations on save Aug 20, 2019

tabacitu closed this Feb 11, 2020

tabacitu deleted the image-uploader-fixes branch February 11, 2020 12:50

This was referenced Apr 2, 2020

Backpack:crud crashes #2630

Closed

Backpack:crud crashes #2631

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.1][Improvement] Image field - allow multiple image uploaders + generate variations on save #124

[4.1][Improvement] Image field - allow multiple image uploaders + generate variations on save #124

OwenMelbz commented Sep 21, 2016

OwenMelbz commented Sep 21, 2016

OwenMelbz commented Oct 11, 2016

OwenMelbz commented Nov 2, 2016 •

edited

Loading

OwenMelbz commented Feb 4, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

lloy0076 Jul 7, 2017

tabacitu commented Feb 11, 2020

OwenMelbz commented Feb 11, 2020

tabacitu commented Feb 11, 2020

[4.1][Improvement] Image field - allow multiple image uploaders + generate variations on save #124

[4.1][Improvement] Image field - allow multiple image uploaders + generate variations on save #124

Conversation

OwenMelbz commented Sep 21, 2016

OwenMelbz commented Sep 21, 2016

OwenMelbz commented Oct 11, 2016

OwenMelbz commented Nov 2, 2016 • edited Loading

OwenMelbz commented Feb 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tabacitu commented Feb 11, 2020

OwenMelbz commented Feb 11, 2020

tabacitu commented Feb 11, 2020

OwenMelbz commented Nov 2, 2016 •

edited

Loading