Feature full screen elfinder windows #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally right, @michaellindahl . I did however remove 2px from the height in order to prevent the scrollbar from showing (can't, for the life of me, figure out where those 2px are coming from). Please tell me if now its full-height for you too or 2px of white space show up at the bottom. They shouldn't, but just to be sure. Also fixed some old issues I had with the "browse" field, which loads elFinder in an iFrame and it didn't look sexy at all. Cheers, thanks a lot! |
This was referenced Apr 2, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off a PR #184.
I thought I would create a separate PR in case there are concerns with this. I tested this with CKEditor and it works great. If this gets swiftly approved I though we could release it in 3.1.28 as well. However, if not, I can update the Readme to a different version.