-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/Bug fix] Added the ability to separate base/crud assets more easily #224
Conversation
@OwenMelbz, I've gotten used to the idea of providing these JS and CSS files, so I'm going to merge this into 3.2 One thing that's related to this and I would have loved: getting rid of the JS that is currently in the blade files, and move it to external .js files. Just look at all the JS that ended up in list.blade.php. The thing is, that JS is in blade files for a reason: it's intertwined with PHP, a lot. I see two options to separate this JS, but I don't like either of them:
Do you see any other option? Do you like any of the above? Thanks! |
Yeah I know what you mean about the inlining of js, and even css there is a lot of. I think the most acceptable reason is also the largest rewrite, it is pretty much what is outlined -> #148 But the concept would be to handle everything via data attributes, so json encoding it and passing it to the JS component which will then handle the logic, this could also work for translations. However it is a large change, maybe a big ol refactor for 4 :D So for maybe now, leaving them inline is the best choice |
Pff... yeah, I agree. Thank you :-) |
Merged into 3.2. |
Have added a new default layer of separation for crud specific css/js assets.
By default users have no way of easily customising the css/js of the CRUD level features
Additionally contributors have no way to make crud specific css/js fixes/features without effecting base.
This adds a series of files list, create, edit, form, revisions, show, reorder etc into the public directory that can be modified