Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Exclude _method from massAssignment #248

Merged
merged 1 commit into from
Nov 29, 2016
Merged

[Bug Fix] Exclude _method from massAssignment #248

merged 1 commit into from
Nov 29, 2016

Conversation

OwenMelbz
Copy link
Contributor

No description provided.

@OwenMelbz OwenMelbz changed the title Exclude _method from massAssignment [Bug Fix] Exclude _method from massAssignment Nov 18, 2016
@tabacitu
Copy link
Member

Hi @OwenMelbz ,

What does this do? I'm sure you're right, but I'm curious :-)

Thanks, cheers!

@OwenMelbz
Copy link
Contributor Author

It's more of a wild goose chase fix, When you have an empty $fillable the update method POSTs a _method which is PUT.

So it throws a mass assignment error, but as it talks about _method in the error it's a little tricker to realize what it's for or debug if your newer to laravel.

So by adding this to the exclude list, users will given a useful error instead which will be easier to identify and fix.

@tabacitu tabacitu changed the base branch from master to 3.2 November 29, 2016 12:40
@tabacitu tabacitu merged commit 0fedb6f into 3.2 Nov 29, 2016
@tabacitu
Copy link
Member

Thank you! Merged into the 3.2 branch.

@tabacitu tabacitu deleted the bug-_method branch November 29, 2016 12:42
This was referenced Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants