[4.1] Clean up Request usage inside CrudController and CrudPanel #2535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Backpack 4.0, when working inside a
ProductCrudController
we had:$this->request
$this->crud->request
which is superfluous and confusing, since:
$this->request
never gets overwritten, and is unavailable inside the CrudPanel object; so it's the same exact thing like using Laravel'srequest()
helper - which I'd argue is cleaner and more intuitive (it looks like a global object); so let's userequest()
instead of$this->request
which does nothing extra;$this->crud->request
has a setter ($this->crud->setRequest()
), but no getter - it's used as a property, which makes it difficult to change what it does;Needs to be documented
ProductCrudController
s, if you're using$this->request
, please replace it withrequest()
; that CrudController property is no longer available, since it basically did the same thing asrequest()
;ProductCrudController
s, if you're using$this->crud->request
, please replace it with its setter or getter ($this->crud->getRequest()
or$this->crud->setRequest()
); the property is now protected;