Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Upgraded line awesome to 1.3.0 and replaced all fa icons with la icons #2554

Merged
merged 9 commits into from
Mar 14, 2020

Conversation

tabacitu
Copy link
Member

Upgraded Line-Awesome to 1.3.0, which provides syntax compatibility with Font Awesome 5.x

Breaking change. Some icon names have changed.
Took the liberty of replacing all icon syntax throughout Backpack from fa fa-home to la la-home, to prevent clashes when using the bootstrap-iconpicker field type.

One problem remains - inside datatables, the ellipsis and ordering carets still don't work:
Screenshot 2020-03-13 at 18 38 15

@tabacitu tabacitu added Priority: SHOULD dependencies Pull requests that update a dependency file labels Mar 13, 2020
@tabacitu
Copy link
Member Author

tabacitu commented Mar 13, 2020

Needs mentioning in the upgrade guide:

  • change path to CSS file in config/base.php file;
  • change fa fa-smth to la la-smth;
  • check that all icons you were using before in your sidebar_content.blade.php still work, or replace them with icons from their website;

@tabacitu tabacitu changed the base branch from update-npm-dependencies to 4.1 March 13, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Priority: SHOULD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants