Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #71 Enables inline errors for fields #287

Merged
merged 7 commits into from
Feb 12, 2017
Merged

Conversation

OwenMelbz
Copy link
Contributor

@OwenMelbz OwenMelbz commented Dec 4, 2016

Setting global defaults

/config/backpack/crud.php

    'errors_inline' => false,
    'errors_grouped' => true,

Setting crud level errors

// enabled/disables grouped errors at the top
$this->crud->enableGroupedErrors();
$this->crud->disableGroupedErrors();

// enables/disables inline errors
$this->crud->enableInlineErrors();
$this->crud->disableInlineErrors();

// check if grouped messages are enabled
$this->crud->isGroupedErrorsEnabled();

// check if inline messages are enabled
$this->crud->isInlineErrorsEnabled();

This addresses #71

@OwenMelbz OwenMelbz changed the title [Enhancement] Enables inline errors for fields [Fixes #71] Enables inline errors for fields Dec 4, 2016
@OwenMelbz OwenMelbz changed the title [Fixes #71] Enables inline errors for fields Fixes #71 Enables inline errors for fields Dec 4, 2016
@tabacitu tabacitu added the URGENT label Jan 8, 2017
@tabacitu tabacitu changed the base branch from master to 3.2 February 10, 2017 08:07
@tabacitu
Copy link
Member

@OwenMelbz - excellent feature, this one.

Please note:

  • I've made some slight changes to the syntax (errorsGrouped into groupedErrors, small things like that);
  • I've made it play nice with the tabs functionality too (tabs also get highlighted if they have fields that errored)

screen shot 2017-02-12 at 12 44 43

Merging it into the 3.2 branch.

Cheers, thanks a lot!

@tabacitu tabacitu merged commit 0c2f2c4 into 3.2 Feb 12, 2017
@tabacitu tabacitu removed the ready label Feb 12, 2017
@tabacitu tabacitu deleted the feature-inline-errors branch November 18, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants