Prettify model preview page #781
Conversation
Added small fix for DBAL to fix enum issue. run setFromDB and remove previously set columns.
| // cycle through old columns for removal | ||
| foreach($this->crud->columns as $old_id => $column) { | ||
| // replace any relationship columns | ||
| if(array_key_exists('model', $column)) { |
There was a problem hiding this comment.
Space after if!!!
Why exists vs isset?
| // get the info for that entry | ||
| $this->data['entry'] = $this->crud->getEntry($id); | ||
| $this->data['crud'] = $this->crud; | ||
| $this->data['title'] = trans('backpack::crud.preview').' '.$this->crud->entity_name; | ||
|
|
||
| // remove preview button from stack:line |
There was a problem hiding this comment.
Because you're already on the "preview" page :-)
| @@ -3,7 +3,7 @@ | |||
| @section('content-header') | |||
| <section class="content-header"> | |||
| <h1> | |||
| {{ trans('backpack::crud.preview') }} <span>{{ $crud->entity_name }}</span> | |||
| {{ trans('backpack::crud.preview') }} <span class="text-lowercase">{{ $crud->entity_name }}</span> | |||
There was a problem hiding this comment.
Why do we have text-lowercase in that span? German, for one, has rules about capitalising nouns for example?
| @@ -15,19 +15,50 @@ | |||
|
|
|||
| @section('content') | |||
| @if ($crud->hasAccess('list')) | |||
| <a href="{{ url($crud->route) }}"><i class="fa fa-angle-double-left"></i> {{ trans('backpack::crud.back_to_all') }} <span>{{ $crud->entity_name_plural }}</span></a><br><br> | |||
| <a href="{{ url($crud->route) }}"><i class="fa fa-angle-double-left"></i> {{ trans('backpack::crud.back_to_all') }} <span class="text-lowercase">{{ $crud->entity_name_plural }}</span></a><br><br> | |||
| @endif | ||
|
|
||
| <!-- Default box --> | ||
| <div class="box"> | ||
| <div class="box-header with-border"> | ||
| <h3 class="box-title"> | ||
| {{ trans('backpack::crud.preview') }} | ||
| <span>{{ $crud->entity_name }}</span> | ||
| <span class="text-lowercase">{{ $crud->entity_name }}</span> |
| <td> | ||
| <strong>{{ $column['label'] }}</strong> | ||
| </td> | ||
| @if (!isset($column['type'])) |
There was a problem hiding this comment.
The indenting below is odd.
| @endforeach | ||
| @if ($crud->buttons->where('stack', 'line')->count()) | ||
| <tr> | ||
| <td><strong>Actions</td> |
There was a problem hiding this comment.
You sure that doesn't have a translation key?
|
@AbbyJanke and @lloy0076 - thanks a lot for this. I've just merged it into dev. @AbbyJanke very good work here. I've made just a few changes - mainly changed how autoSet() works - instead of creating the columns/fields no matter what, it only creates them if they're not already set. This allows us to use the "preview" functionality for non-autoset CRUDs too, and columns that have been defined by the user will look like he said, columns that he hasn't will look autoset. In most cases, this means the relationship columns won't be stripped out anymore. They'll just be pretty :-) Again, thanks a lot for this, glad I've finally been able to merge this. Cheers! Thanks for using Backpack. |
As discussed in PR #750 simplified the preview page. Automatically pulls all columns from the database using
setFromDB()removes any previously set columns withinsetup()function.Also added small fix for
setFromDB()to solve DBAL to fix enum issue. Code from issue #236.