Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+5 icons #2572

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

+5 icons #2572

wants to merge 9 commits into from

Conversation

Soupfullyy
Copy link

Description

Icons addition information

Added

Beatronome (com.liquidvoid.beatronome)
Bookshelf (com.com.bookshelf.prod)
Bunpo (com.bunpoapp)
萌娘百科 ~~ Moegirlpedia (org.moegirl.moegirlview)
O'Reilly (com.safariflow.queue)

Tiara added 2 commits February 27, 2025 03:00
Beatronome(com.liquidvoid.beatronome)
Bookshelf(com.com.bookshelf.prod)
Bunpo(com.bunpoapp)
萌娘百科 ~~ Moegirlpedia(org.moegirl.moegirlview)
O'Reilly(com.safariflow.queue)
@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Feb 26, 2025
Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@x9136
Copy link
Collaborator

x9136 commented Mar 2, 2025

Hey! Most of the icons don't fit the Lawnicons guidelines. bunpo.svg is the most suitable icon, but it's also aligned without taking into account the visual center and has lost its quality due to the flimsy bends of the lines.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Mar 2, 2025
@Soupfullyy
Copy link
Author

Updated the icons, tried to align to visual center but not sure if it looks okay.

@x9136
Copy link
Collaborator

x9136 commented Mar 14, 2025

Since the last update, there have been more discrepancies with the Lawnicons guidelines.

I fixed 4 icons for you, you can compare what has changed. I suggest correcting or deleting the last icon so that I can accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants