✨(lld): add empty message and dummy drawer for ordis #7881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
live-github-bot
bot
added
desktop
apps/ledger-live-desktop/src/newArch/features/Collectibles/Ordinals/components/Error.tsx
Outdated
Show resolved
Hide resolved
| if (items.length > 3) setDisplayShowMore(true); | ||
| setDisplayedObjects(items.slice(0, 3)); | ||
| }, [items]); | ||
| if (displayedObjects.length === 0) { |
There was a problem hiding this comment.
I don't understand this
There was a problem hiding this comment.
It's to avoid to trigger it at each re render. Sometimes (and when a drawer just opened) displayedObjects comes back to his initial state with only 3 object in it. So I trigger it only at the first render
There was a problem hiding this comment.
I've changed to not do it with a use Effect to make easier to read
apps/ledger-live-desktop/src/newArch/features/Collectibles/hooks/useFetchOrdinals.ts
Outdated
Show resolved
Hide resolved
LucasWerey
force-pushed
the
feat/ordis-a
branch
from
4495cc0 to
b829c8c
Compare
LucasWerey
force-pushed
the
feat/ordis-a
branch
from
b829c8c to
559190c
Compare
mcayuelas-ledger
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add empty state in table for inscriptions and rare sats
Add error message to error row
Add dummy drawer that will be replaced by the good one in next pr
Screen.Recording.2024-09-24.at.09.58.41.mov
❓ Context
🧐 Checklist for the PR Reviewers