Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pnpm to 9.11 #7893

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Upgrade pnpm to 9.11 #7893

merged 1 commit into from
Sep 26, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Sep 25, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Upgrade pnpm to version 9.11 and activate catalog feature.
https://pnpm.io/catalogs

This has a great impact on duplicates dependencies.
I used the codemod to generate our catalog, which can be improved on demand.
pnpx codemod pnpm/catalog

I also added react and react-dom manually, and this resulted in a bump from 18.2 to 18.3.1. This might not have any impact as the 18.3 version only includes warnings about deprecated features for React 19 migration.

Screenshot 2024-09-25 at 09 56 39

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Sep 25, 2024
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Sep 25, 2024
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 7:50am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 7:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 7:50am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 7:50am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 7:50am

@live-github-bot live-github-bot bot added the automation CI/CD stuff label Sep 25, 2024
@KVNLS KVNLS force-pushed the fix/upgrade-pnpm-9-11 branch 3 times, most recently from 31b616a to 9837b2e Compare September 25, 2024 11:50
@KVNLS KVNLS marked this pull request as ready for review September 25, 2024 13:13
@KVNLS KVNLS requested review from a team as code owners September 25, 2024 13:13
@KVNLS KVNLS requested a review from a team September 25, 2024 13:13
@KVNLS KVNLS requested a review from a team as a code owner September 25, 2024 13:13
valpinkman
valpinkman previously approved these changes Sep 25, 2024
Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€ nice

@KVNLS
Copy link
Member Author

KVNLS commented Sep 26, 2024

As found by @valpinkman we should wait for renovate support before using the catalog feature.
renovatebot/renovate#30079
I will remove commits related to catalog.

@KVNLS KVNLS dismissed stale reviews from valpinkman and ypolishchuk-ledger via c80b4b0 September 26, 2024 07:50
@KVNLS KVNLS force-pushed the fix/upgrade-pnpm-9-11 branch from 9837b2e to c80b4b0 Compare September 26, 2024 07:50
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Sep 26, 2024
@live-github-bot live-github-bot bot removed ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs automation CI/CD stuff cli labels Sep 26, 2024
@KVNLS KVNLS merged commit 1f583cc into develop Sep 26, 2024
33 of 46 checks passed
@KVNLS KVNLS deleted the fix/upgrade-pnpm-9-11 branch September 26, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants