fix: fix sellNg and fundNg #8027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
common
sarneijim
force-pushed
the
fix/fix-sell-ng
branch
from
6ce5c76 to
6972450
Compare
sarneijim
force-pushed
the
fix/fix-sell-ng
branch
from
6972450 to
e842668
Compare
sprohaszka-ledger
requested changes
Oct 7, 2024
There was a problem hiding this comment.
It could be great to start adding some test time to time.
I am not fully confident about the flow that will be triggered with CHECK_ASSET_IN_AND_DISPLAY.
I would like that we don't generalize the fact that using a flow (ex: FUND), will in reality triggered the behaviour of another one (ex: SELL).
libs/ledger-live-common/src/exchange/platform/transfer/completeExchange.ts
Show resolved
Hide resolved
|
Generating screenshots: workflow ended Jobs status: |
sprohaszka-ledger
approved these changes
Oct 8, 2024
sergiubreban
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
SellNG and FundNg.
❓ Context
🧐 Checklist for the PR Reviewers