Skip to content

Commit

Permalink
ci: remove nodejs v12 exclusion logic from run custom checks
Browse files Browse the repository at this point in the history
Fixes hyperledger-cacti#1961

Signed-off-by: Youngone Lee <[email protected]>
  • Loading branch information
Leeyoungone committed Apr 20, 2022
1 parent dda3f00 commit 6adb386
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions tools/custom-checks/run-custom-checks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ export async function runCustomChecks(
let overallSuccess = true;
let overallErrors: string[] = [];

const [majorVersion] = version.split(".");
const nodeV12OrOlder = parseInt(majorVersion) <= 12;
if (nodeV12OrOlder) {
console.log(`${TAG} Checks skipped due to old NodeJS (v${version}) OK.`);
return;
}
console.log("${TAG} Current NodeJS version is v", version);
// const [majorVersion] = version.split(".");
// const nodeV12OrOlder = parseInt(majorVersion) <= 12;
// if (nodeV12OrOlder) {
// console.log(`${TAG} Checks skipped due to old NodeJS (v${version}) OK.`);
// return;
// }

{
const [success, errors] = await checkOpenApiJsonSpecs({ argv, env });
Expand Down

0 comments on commit 6adb386

Please sign in to comment.