Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fabric legacy CLI #20588

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Remove fabric legacy CLI #20588

merged 4 commits into from
Feb 13, 2025

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Feb 13, 2025

What does this PR do?

Removes legacy support for lightning run model in favor of fabric run.
Currently, depending on the installation order, lightning run might go from legacy CLI here to the lightning-sdk including intermediate numpy and torch imports slowing down the CLI drastically.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20588.org.readthedocs.build/en/20588/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success
pl-cpu (macOS-14, lightning, 3.10, 2.1) success
pl-cpu (macOS-14, lightning, 3.11, 2.2.2) success
pl-cpu (macOS-14, lightning, 3.11, 2.3) success
pl-cpu (macOS-14, lightning, 3.12.7, 2.4.1) success
pl-cpu (macOS-14, lightning, 3.12.7, 2.5.1) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
pl-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1) success
pl-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1) success
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.11, 2.2.2) success
pl-cpu (windows-2022, lightning, 3.11, 2.3) success
pl-cpu (windows-2022, lightning, 3.12.7, 2.4.1) success
pl-cpu (windows-2022, lightning, 3.12.7, 2.5.1) success
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success
pl-cpu (macOS-14, pytorch, 3.12.7, 2.5.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.12.7, 2.5.1) success
pl-cpu (windows-2022, pytorch, 3.12.7, 2.5.1) success

These checks are required after the changes to src/lightning/fabric/cli.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/fabric/cli.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/fabric/cli.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/cli.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2) success
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success
fabric-cpu (macOS-14, lightning, 3.12.7, 2.4.1) success
fabric-cpu (macOS-14, lightning, 3.12.7, 2.5.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.4.1) success
fabric-cpu (ubuntu-22.04, lightning, 3.12.7, 2.5.1) success
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2) success
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success
fabric-cpu (windows-2022, lightning, 3.12.7, 2.4.1) success
fabric-cpu (windows-2022, lightning, 3.12.7, 2.5.1) success
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success
fabric-cpu (macOS-14, fabric, 3.12.7, 2.5.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.12.7, 2.5.1) success
fabric-cpu (windows-2022, fabric, 3.12.7, 2.5.1) success

These checks are required after the changes to src/lightning/fabric/cli.py, tests/tests_fabric/test_cli.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/fabric/cli.py, tests/tests_fabric/test_cli.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/fabric/cli.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.9) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.9) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.9) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-14, fabric, 3.9) success
install-pkg (macOS-14, fabric, 3.11) success
install-pkg (macOS-14, pytorch, 3.9) success
install-pkg (macOS-14, pytorch, 3.11) success
install-pkg (macOS-14, lightning, 3.9) success
install-pkg (macOS-14, lightning, 3.11) success
install-pkg (macOS-14, notset, 3.9) success
install-pkg (macOS-14, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.9) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.9) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.9) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.9) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/__setup__.py, src/lightning/fabric/cli.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (d902516) to head (6bff2a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20588   +/-   ##
=======================================
  Coverage      88%      88%           
=======================================
  Files         267      267           
  Lines       23380    23369   -11     
=======================================
- Hits        20481    20478    -3     
+ Misses       2899     2891    -8     

@justusschock justusschock merged commit 9afcc58 into master Feb 13, 2025
101 of 103 checks passed
@justusschock justusschock deleted the remove_legacy_ci branch February 13, 2025 23:45
Borda pushed a commit that referenced this pull request Feb 14, 2025
(cherry picked from commit 9afcc58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants