-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable_autolog_hparams
argument to Trainer.
#20593
base: master
Are you sure you want to change the base?
Add enable_autolog_hparams
argument to Trainer.
#20593
Conversation
for more information, see https://pre-commit.ci
…m/duydl/pytorch-lightning into feature/option-disable-loghparams
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20593 +/- ##
=========================================
- Coverage 88% 79% -9%
=========================================
Files 267 264 -3
Lines 23373 23320 -53
=========================================
- Hits 20483 18374 -2109
- Misses 2890 4946 +2056 🚀 New features to boost your workflow:
|
@Borda Thank you. Please merge when convenient. |
enable_autolog_hparams
argument to Trainer.
@lantiga mind sharing your point of view on this new Trainer's flag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @duydl, I'm good with the new argument.
What does this PR do?
This PR provides flexibility for users who prefer to handle hyperparameter logging differently.
Possibly address #19889 .
No breaking changes.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20593.org.readthedocs.build/en/20593/