Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing kwargs in PIT metric for permutation wise mode #2977

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 26, 2025

What does this PR do?

Fixes #2907

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2977.org.readthedocs.build/en/2977/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Feb 26, 2025
@SkafteNicki SkafteNicki added this to the v1.5.x milestone Feb 26, 2025
@SkafteNicki SkafteNicki self-assigned this Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36%. Comparing base (3c01c57) to head (2e1a8da).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3c01c57) and HEAD (2e1a8da). Click for more details.

HEAD has 52 uploads less than BASE
Flag BASE (3c01c57) HEAD (2e1a8da)
torch2.0.1+cpu 6 3
python3.10 18 9
Windows 4 2
cpu 27 14
torch2.6.0+cpu 2 1
python3.12 5 3
macOS 5 3
torch2.0.1 4 2
Linux 18 9
torch2.3.1+cpu 2 1
python3.9 2 1
torch2.4.1+cpu 4 2
python3.11 2 1
torch2.2.2+cpu 2 1
torch2.5.0+cpu 4 2
torch2.1.2+cpu 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2977     +/-   ##
========================================
- Coverage      70%     36%    -34%     
========================================
  Files         348     348             
  Lines       19469   19469             
========================================
- Hits        13607    6973   -6634     
- Misses       5862   12496   +6634     

@mergify mergify bot added the ready label Feb 26, 2025
@Borda Borda merged commit 10d4398 into master Feb 27, 2025
60 checks passed
@Borda Borda deleted the bugfix/pit_permutation_wise_missing_kwargs branch February 27, 2025 10:22
Borda pushed a commit that referenced this pull request Feb 28, 2025
* add missing kwargs
* add testing
* changelog

(cherry picked from commit 10d4398)
Borda pushed a commit that referenced this pull request Mar 3, 2025
* add missing kwargs
* add testing
* changelog

(cherry picked from commit 10d4398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Audio
Projects
None yet
2 participants