feat: adjust frame-background-mode automatically
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So themes that support the `background` face spec characteristic work with Auto-Dark. Fixes LionyxML#55.
|
I just realized that the file got autoformatted. Let me know if that’s an issue and I can revert those bits. |
sellout
added a commit
to sellout/auto-dark-emacs
that referenced
this pull request
Jul 7, 2024
Like `custom-enabled-themes`, Auto-Dark now allows multiple themes to be set for either each mode. It also now defaults to using `custom-enabled-themes` if there is nothing explicitly set for Auto-Dark. Because (dis|en)abling themes modifies `custom-enabled-themes`, you either have to set both the dark-themes and light-themes or neither, so there is a single new variable `auto-dark-themes` that manages both lists. If neither the new variable nor `custom-enabled-themes` is set, then it falls back to the pre-existing single theme behavior, which is now marked obsolete. With this change[^1] I can now configure my themes like ```elisp (use-package emacs :custom (custom-enabled-themes '(bringhurst solarized inheritance))) (use-package auto-dark :init (auto-dark-mode)) ``` (since my themes all support dark/light modes). [^1]: This change is built on LionyxML#56, because it doesn’t make sense to use `custom-enabled-themes` with Auto-Dark unless it updates `frame-background-mode`.
- undo unrelated auto-formatting - use ASCII for docstring quotes - minor phrasing adjustments in docstring
|
Thanks for the quick review and encouragement. I have hopefully addressed everything. I don’t know how I overlooked Auto-Dark for so long. |
LionyxML
changed the title
frame-background-mode automaticallyframe-background-mode automatically
sellout
added a commit
to sellout/auto-dark-emacs
that referenced
this pull request
Jul 14, 2024
Like `custom-enabled-themes`, Auto-Dark now allows multiple themes to be set for either each mode. It also now defaults to using `custom-enabled-themes` if there is nothing explicitly set for Auto-Dark. Because (dis|en)abling themes modifies `custom-enabled-themes`, you either have to set both the dark-themes and light-themes or neither, so there is a single new variable `auto-dark-themes` that manages both lists. If neither the new variable nor `custom-enabled-themes` is set, then it falls back to the pre-existing single theme behavior, which is now marked obsolete. With this change[^1] I can now configure my themes like ```elisp (use-package emacs :custom (custom-enabled-themes '(bringhurst solarized inheritance))) (use-package auto-dark :init (auto-dark-mode)) ``` (since my themes all support dark/light modes). [^1]: This change is built on LionyxML#56, because it doesn’t make sense to use `custom-enabled-themes` with Auto-Dark unless it updates `frame-background-mode`.
LionyxML
pushed a commit
that referenced
this pull request
Sep 14, 2024
* Support multiple themes Like `custom-enabled-themes`, Auto-Dark now allows multiple themes to be set for either each mode. It also now defaults to using `custom-enabled-themes` if there is nothing explicitly set for Auto-Dark. Because (dis|en)abling themes modifies `custom-enabled-themes`, you either have to set both the dark-themes and light-themes or neither, so there is a single new variable `auto-dark-themes` that manages both lists. If neither the new variable nor `custom-enabled-themes` is set, then it falls back to the pre-existing single theme behavior, which is now marked obsolete. With this change[^1] I can now configure my themes like ```elisp (use-package emacs :custom (custom-enabled-themes '(bringhurst solarized inheritance))) (use-package auto-dark :init (auto-dark-mode)) ``` (since my themes all support dark/light modes). [^1]: This change is built on #56, because it doesn’t make sense to use `custom-enabled-themes` with Auto-Dark unless it updates `frame-background-mode`. * Update the README to match these changes * Update the version to 0.13 * Improve variable documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So themes that support the
backgroundface spec characteristic work with Auto-Dark.Fixes #55.