Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-3236 Uncomment "Add sensor" to Add farm map drawer #2663

Merged

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented May 3, 2023

Description

GOOD TO MERGE NOW! 😄

This PR restores sensors to the Farm Map drawer.

Jira link: https://lite-farm.atlassian.net/browse/LF-3236

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini requested a review from SayakaOno May 4, 2023 20:38
@SayakaOno SayakaOno merged commit 1c17d3a into integration May 4, 2023
@iperdomo iperdomo deleted the LF-3236-uncomment-add-sensor-to-add-farm-map-drawer branch August 3, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants