-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LF-4612c Fix margin on icons without checkbox #3612
Conversation
className={clsx( | ||
styles.tableCell, | ||
dense && styles.dense, | ||
shouldShowCheckbox && id === 'identification' && styles.afterCheckbox, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be ideal if we could avoid bringing an animal specific column...
Is it possible to add the style to animalsColumns
in Inventory container like we do for the arrow?
{
id: showLinks ? 'path' : null,
label: '',
format: (d: AnimalInventoryItem) => (
<Cell kind={CellKind.RIGHT_CHEVRON_LINK} path={d.path} />
),
columnProps: {
style: { width: '40px', padding: `0 ${isDesktop ? 12 : 8}px` },
},
sortable: false,
},
I hope the container knows if it needs to show checkboxes or not 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SayakaOno could you open a PR to demo what you're thinking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it can't be done with columnProps!! I realized it after looking at the code carefully...
Instead, I tried adding a className to the cell. Here's the test code: a889d3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a much better solution and actually it probably would have saved me so prop passing to do that earlier, for removed! ❤️
…th_cell_className LF-4612c (2): Adjust margin with cell className
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test in on beta!
Description
Thank you @SayakaOno for remembering the checkbox-less view 🙏 🙏 🙏
Jira link: https://lite-farm.atlassian.net/browse/LF-4612
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: