Delay registering the Gamepad Hook #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the web we support gamepads. Unfortunately there's no callbacks or so that we could use, so instead we have to use an interval where we poll for button presses. This isn't super expensive, but still unnecessary if you don't use a gamepad. Additionally Chrome has the problem that it gets exclusive access to the gamepads and doesn't really yield control back until the whole browser is closed. So you really don't want that unless you really intend to use the gamepad for splitting. This is why the gamepad interval is now only being set when the first gamepad button is registered.
CryZe
added
enhancement
wooferzfg
approved these changes
Jun 14, 2020
| @@ -31,11 +34,37 @@ impl Drop for Hook { | |||
| "keypress", | |||
| self.keyboard_callback.as_ref().unchecked_ref(), | |||
| ); | |||
| window.clear_interval_with_handle(self.interval_id); | |||
| if let Some(interval_id) = self.interval_id.get() { | |||
| window.clear_interval_with_handle(interval_id); | |||
There was a problem hiding this comment.
It's definitely an edge case, but should we also be calling this in unregister if there's no more gamepad buttons registered anymore?
There was a problem hiding this comment.
I don't think that case matters much, as I think it's a super rare situation that someone was using gamepad, then stops using gamepad. And even then, the cost for the gamepad hook is still very minimal, and it stops being a cost the next time they reload. So overall, I'd say yes, we could possibly remove the hook when unregistering all gamepad buttons, but it has a much lesser impact.
CryZe
added a commit
to CryZe/LiveSplitOne
that referenced
this pull request
Jun 14, 2020
This updates livesplit-core which brings a variety of performance improvements: - The Layout State is now being reused and thus most frames don't require any heap allocations anymore. However we still serialize everything over into a JSON string for now, which puts a lot of garbage on the JS heap. LiveSplit/livesplit-core#334 - The frequent performance.now() calls we do, first lookup up the window and performance object every time. This tripled the amount of calls we do over into JavaScript, with each call into JavaScript being quite expensive in Chrome. LiveSplit/livesplit-core#335 - By introducing a timer snapshot mechanism we further reduce the calls to performance.now() to a single time. LiveSplit/livesplit-core#339 - Rust 1.44 regressed the performance of 128-bit integer multiplications by accident. Those are used for hashing the comparisons when looking up the times for a comparison, which is something we do very frequently. We however don't have many comparisons, so a simple Vec that we loop through is a bit faster, even in native code, and quite a bit faster in the web, because of the Rust 1.44 regression. LiveSplit/livesplit-core#338 - We delay registering the Gamepad Hook Interval until the first gamepad button is registered. Most people won't use a gamepad, so the interval just waits cpu time for no reason. LiveSplit/livesplit-core#340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the web we support gamepads. Unfortunately there's no callbacks or so that we could use, so instead we have to use an interval where we poll for button presses. This isn't super expensive, but still unnecessary if you don't use a gamepad. Additionally Chrome has the problem that it gets exclusive access to the gamepads and doesn't really yield control back until the whole browser is closed. So you really don't want that unless you really intend to use the gamepad for splitting. This is why the gamepad interval is now only being set when the first gamepad button is registered.