-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Alternative for K8s Dashboard #45
base: main
Are you sure you want to change the base?
Conversation
The way written in for Kubernetes Dashboard is only for localhost to use it using https by a virtual machine you need to do it this way.
WalkthroughThe pull request updates the documentation in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
kind-cluster/README.md (2)
126-134
: Clarify Alternative Access Instructions for the Kubernetes Dashboard
The added alternative instructions to run port-forwarding when the default proxy method fails is a useful addition for VM users. However, the wording on line 133—specifically, "Make sure you click on the Advance option, which you dohttps
"—is ambiguous and may confuse users. Consider rephrasing this sentence for clarity and addressing the possible punctuation issue flagged by static analysis.Diff suggestion:
-You can access the Kubernetes Dashboard at `https://your-ip:8443`. Paste your token and advance to Kubernetes Dashboard. Make sure you click on the Advance option, which you do `https`. +You can access the Kubernetes Dashboard at `https://your-ip:8443`. Paste your token and, if prompted, click on the "Advanced" button to proceed to the Kubernetes Dashboard.🧰 Tools
🪛 LanguageTool
[uncategorized] ~133-~133: Possible missing comma found.
Context: ... click on the Advance option, which you dohttps
. ## 5. Deleting the Cluster De...(AI_HYDRA_LEO_MISSING_COMMA)
144-144
: Improve Clarity in the Multiple Clusters Note
The revised note in the "Notes" section now reads, "Multiple Clusters: KIND supports multiple clusters. Use a unique name for each cluster. Using --name". The fragment "Using --name" comes off as incomplete or ambiguous. Consider fully rewording the note to explain that when creating multiple clusters, each must have a unique name—this can be accomplished by specifying the--name
option.Diff suggestion:
-Multiple Clusters: KIND supports multiple clusters. Use a unique name for each cluster. Using --name +Multiple Clusters: KIND supports multiple clusters. Ensure each cluster has a unique name by using the `--name` option during cluster creation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
kind-cluster/README.md
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
kind-cluster/README.md
[uncategorized] ~133-~133: Possible missing comma found.
Context: ... click on the Advance option, which you do https
. ## 5. Deleting the Cluster De...
(AI_HYDRA_LEO_MISSING_COMMA)
The way written in for Kubernetes Dashboard is only for localhost to use it using https by a virtual machine you need to do it this way.
Summary by CodeRabbit