Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Optimisers.jl patch #1247

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix: remove Optimisers.jl patch #1247

wants to merge 9 commits into from

Conversation

avik-pal
Copy link
Member

No description provided.

@avik-pal avik-pal force-pushed the ap/optimizers_nopatch branch 2 times, most recently from 3161948 to 79e5349 Compare February 27, 2025 03:16
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Benchmark Results (ASV)

main 421d309... main/421d309069c28b...
basics/overhead 0.124 ± 0.0014 μs 0.124 ± 0.0016 μs 0.998
time_to_load 0.909 ± 0.0058 s 0.911 ± 0.012 s 0.998

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal force-pushed the ap/optimizers_nopatch branch from 79e5349 to bed8b13 Compare March 6, 2025 22:01
@avik-pal avik-pal linked an issue Mar 6, 2025 that may be closed by this pull request
24 tasks
@avik-pal
Copy link
Member Author

avik-pal commented Mar 7, 2025

in expression starting at REPL[21]:1
BufferToDevice at /mnt/.julia/artifacts/cc62e427b86ed512be8bf4c576f9843a92204c84/lib/libReactantExtra.so (unknown line)
jfptr_device_21988 at /mnt/.julia/compiled/v1.11/Reactant/p9PzF_aaTDh.so (unknown line)
__resolve_device_and_client at /mnt/software/lux/Reactant.jl/src/Compiler.jl:1619
unknown function (ip: 0x7533e33c7223)
#compile_xla#39 at /mnt/software/lux/Reactant.jl/src/Compiler.jl:1675
compile_xla at /mnt/software/lux/Reactant.jl/src/Compiler.jl:1652 [inlined]
#compile#40 at /mnt/software/lux/Reactant.jl/src/Compiler.jl:1717
compile at /mnt/software/lux/Reactant.jl/src/Compiler.jl:1716 [inlined]
macro expansion at /mnt/software/lux/Reactant.jl/src/Compiler.jl:1164 [inlined]
single_train_step_impl at /mnt/software/lux/Lux.jl/ext/LuxReactantExt/training.jl:99
#single_train_step#7 at /mnt/software/lux/Lux.jl/src/helpers/training.jl:313 [inlined]
single_train_step at /mnt/software/lux/Lux.jl/src/helpers/training.jl:309
unknown function (ip: 0x753342f4e9b7)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
do_call at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:126
eval_value at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:223
eval_stmt_value at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:174 [inlined]
eval_body at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:663
jl_interpret_toplevel_thunk at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:821
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:943
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:886
eval_body at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:625
eval_body at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:539
jl_interpret_toplevel_thunk at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/interpreter.c:821
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:943
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:886
jl_toplevel_eval_flex at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:886
ijl_toplevel_eval_in at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/toplevel.c:994
eval at ./boot.jl:430 [inlined]
eval_user_input at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:245
repl_backend_loop at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:342
#start_repl_backend#59 at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:327
start_repl_backend at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:324
#run_repl#72 at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:483
run_repl at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:469
jfptr_run_repl_10119 at /mnt/.julia/compiled/v1.11/REPL/u0gqU_gCry3.so (unknown line)
#1150 at ./client.jl:446
jfptr_YY.1150_14727 at /mnt/.julia/compiled/v1.11/REPL/u0gqU_gCry3.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
jl_f__call_latest at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/builtins.c:875
#invokelatest#2 at ./essentials.jl:1055 [inlined]
invokelatest at ./essentials.jl:1052 [inlined]
run_main_repl at ./client.jl:430
repl_main at ./client.jl:567 [inlined]
_start at ./client.jl:541
jfptr__start_73609.1 at /home/avikpal/.julia/juliaup/julia-1.11.3+0.x64.linux.gnu/lib/julia/sys.so (unknown line)
jl_apply at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/julia.h:2157 [inlined]
true_main at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/jlapi.c:900
jl_repl_entrypoint at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/src/jlapi.c:1059
main at /cache/build/builder-demeter6-3/julialang/julia-release-1-dot-11/cli/loader_exe.c:58
unknown function (ip: 0x7534ac87c487)
__libc_start_main at /usr/lib/libc.so.6 (unknown line)
unknown function (ip: 0x4010b8)
Allocations: 352625449 (Pool: 352620480; Big: 4969); GC: 309
[1]    253622 segmentation fault (core dumped)  julia --project=envs/reactant --threads=auto

@avik-pal avik-pal force-pushed the ap/optimizers_nopatch branch 2 times, most recently from 3ea14d3 to 82032a5 Compare March 7, 2025 18:07
@avik-pal avik-pal force-pushed the ap/optimizers_nopatch branch from 82032a5 to a92fa3b Compare March 7, 2025 22:12
@avik-pal
Copy link
Member Author

avik-pal commented Mar 7, 2025

Definitely a reactant bug. One of the result buffers are left unset

@avik-pal avik-pal force-pushed the ap/optimizers_nopatch branch from 37aa858 to d93cc8f Compare March 8, 2025 18:30
@avik-pal
Copy link
Member Author

avik-pal commented Mar 8, 2025

needs FluxML/Optimisers.jl#210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimisers.jl patch for Reactant Support
1 participant