Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port for AMD #41

Closed
lukim007 opened this issue Jun 14, 2023 · 19 comments
Closed

port for AMD #41

lukim007 opened this issue Jun 14, 2023 · 19 comments
Labels
wontfix This will not be worked on

Comments

@lukim007
Copy link

can you pls in the future make a port for AMD

@ghost
Copy link

ghost commented Jun 15, 2023

nvidium is the first to use nvidia opengle technologies

therefore, it is unlikely that this is possible on amd, but I probably don’t know something

@CrabbyDisk
Copy link

Appearantly AMD gpus support mesh shaders wich is what nvidium uses. This could be possible.

@Inconn
Copy link

Inconn commented Jul 20, 2023

i believe to support other gpus it would require vulkan, since mesh shaders on other gpus are only available on vulkan.
on opengl, only nvidia mesh shaders are supported.

@MCRcortex MCRcortex added the wontfix This will not be worked on label Jul 29, 2023
@MCRcortex
Copy link
Owner

Would not do it in this mod if i did such a thing sorry, yea you are correct, vk mesh shaders do exist but its different from the nv extension

@nonetrix
Copy link

nonetrix commented Sep 8, 2023

I don't expect this to ever be ported, but could a AMD equivalent be made? Surely there are some AMD specific OpenGL extensions that could boost performance greatly as well, maybe someone else could work on this perhaps I would like to see it. I'm just throwing this out as a suggestion, so maybe someone picks it up

I found this list that might be of use, doesn't seem as extensive as the NVIDIA one so maybe AMD sticks more to standards. Still might be some gains to be made perhaps, I don't know much about graphics programming
https://registry.khronos.org/OpenGL/extensions/AMD/

@Funtimes909
Copy link

Hey, I'd love to see an AMD version of this mod using AMD specific OpenGL extensions too, unfortunately I know little to nothing about graphics programming myself however it is possible to convert OpenGL programs to vulkan using drivers such as zink
https://www.khronos.org/assets/uploads/developers/presentations/Vulkan-09-Zink-OpenGL-on-Vulkan-SIGGRAPH-Jul19.pdf
However I also understand if you do not want to work on an AMD port if this mod is tiring enough 😅

@Andarwinux
Copy link

Zink won't magically increase fps, but it could theoretically be used as an interop bridge to provide VulkanMod with compatibility with legacy OpenGL mods.

@nonetrix
Copy link

nonetrix commented Sep 9, 2023

Zink won't magically increase fps, but it could theoretically be used as an interop bridge to provide VulkanMod with compatibility with legacy OpenGL mods.

In some cases it actually does, but this seems to be the exception rather than the rule. I wouldn't know if Minecraft if one of these edge cases. However, no mod is needed for Zink itself, to my understanding any OpenGL program should be able to use it provided theirs no issues

@Andarwinux
Copy link

Zink itself is straightforward to use, but it's almost impossible to get a performance boost unless the IHV only provides inferior native OpenGL drivers and also provides quality Vulkan drivers, which is not the case for Windows desktop devices. IHVs that have a quality Vulkan driver also offer a quality OpenGL driver, and IHVs that only have an inferior OpenGL driver won't offer a quality Vulkan driver to give you high performance with Zink. The only way to potentially bring performance gains is to use native Vulkan rendering like VulkanMod, and then use Zink for VK<->GL interop to provide compatibility with legacy mods, like X-Plane.

@nonetrix
Copy link

nonetrix commented Sep 9, 2023

Zink itself is straightforward to use, but it's almost impossible to get a performance boost unless the IHV only provides inferior native OpenGL drivers and also provides quality Vulkan drivers, which is not the case for Windows desktop devices. IHVs that have a quality Vulkan driver also offer a quality OpenGL driver, and IHVs that only have an inferior OpenGL driver won't offer a quality Vulkan driver to give you high performance with Zink. The only way to potentially bring performance gains is to use native Vulkan rendering like VulkanMod, and then use Zink for VK<->GL interop to provide compatibility with legacy mods, like X-Plane.

True, but there is still edge cases technically. Probably could eliminate them if someone cared enough, but they exist technically
https://www.phoronix.com/review/zink-radeon-august2022

@ColonelGerdauf
Copy link

Hey, I'd love to see an AMD version of this mod using AMD specific OpenGL extensions too, unfortunately I know little to nothing about graphics programming myself however it is possible to convert OpenGL programs to vulkan using drivers such as zink

https://www.khronos.org/assets/uploads/developers/presentations/Vulkan-09-Zink-OpenGL-on-Vulkan-SIGGRAPH-Jul19.pdf

However I also understand if you do not want to work on an AMD port if this mod is tiring enough 😅

I don't think that is possible, given that AMD strictly abides by the original specifications of OpenGL. The AMD-optimized build is… standalone Sodium.

@nonetrix
Copy link

nonetrix commented Sep 18, 2023

Hey, I'd love to see an AMD version of this mod using AMD specific OpenGL extensions too, unfortunately I know little to nothing about graphics programming myself however it is possible to convert OpenGL programs to vulkan using drivers such as zink
https://www.khronos.org/assets/uploads/developers/presentations/Vulkan-09-Zink-OpenGL-on-Vulkan-SIGGRAPH-Jul19.pdf
However I also understand if you do not want to work on an AMD port if this mod is tiring enough 😅

I don't think that is possible, given that AMD strictly abides by the original specifications of OpenGL. The AMD-optimized build is… standalone Sodium.

I would assume this applies to Vulkan too? If not I guess someone could make something like this for the Vulkan Mod https://github.com/xCollateral/VulkanMod but I doubt it's a exception

@Andarwinux
Copy link

The OpenGL team has replied that they have plan to support mesh shader for AMD OpenGL driver in the future.
Thanks.

https://community.amd.com/t5/opengl-vulkan/is-mesh-shader-support-planned-for-opengl/m-p/649970/highlight/true#M5068

@nonetrix
Copy link

nonetrix commented Jan 4, 2024

Neat, but will something similar be added to RadeonSI/Mesa drivers? Maybe worth mentioning on the Gitlab for Mesa?

@PeterStrick
Copy link

Neat, but will something similar be added to RadeonSI/Mesa drivers? Maybe worth mentioning on the Gitlab for Mesa?

Fairly certain if the OpenGL Team has plans to add Mesh Shaders to the OpenGL driver, they will first appear on Mesa and then on Windows

@nixigaj
Copy link

nixigaj commented Jan 22, 2024

Neat, but will something similar be added to RadeonSI/Mesa drivers? Maybe worth mentioning on the Gitlab for Mesa?

Just gonna link this issue here for those interested in this topic: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7192

@RokeJulianLockhart
Copy link

#41 (comment)

#138 (comment) is a potential solution to this, @lukim007.

@IGN-Styly
Copy link

We are going to get the opengl function required for this mod in a later opengl version.

@ImBehinYa
Copy link

I opened an issue in AMD's new driver forum on GitHub and already received a response. They are aiming for the end of the year. Maybe you should comment or react so they see that this matters to us.

GPUOpen-Drivers/AMD-Gfx-Drivers#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests